From: stefano.stabellini@eu.citrix.com
To: linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xensource.com, konrad.wilk@oracle.com,
jeremy@goop.org, Stefano.Stabellini@eu.citrix.com,
yinghai@kernel.org, hpa@linux.intel.com, mingo@elte.hu,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH 1/4] xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf_top
Date: Tue, 12 Apr 2011 12:19:49 +0100 [thread overview]
Message-ID: <1302607192-21355-1-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1104121149280.22672@kaball-desktop>
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
mask_rw_pte is currently checking if a pfn is a pagetable page if it
falls in the range pgt_buf_start - pgt_buf_end but that is incorrect
because pgt_buf_end is a moving target: pgt_buf_top is the real
boundary.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
arch/x86/xen/mmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index c82df6c..6b833db 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -1491,7 +1491,7 @@ static __init pte_t mask_rw_pte(pte_t *ptep, pte_t pte)
* it is RO.
*/
if (((!is_early_ioremap_ptep(ptep) &&
- pfn >= pgt_buf_start && pfn < pgt_buf_end)) ||
+ pfn >= pgt_buf_start && pfn < pgt_buf_top)) ||
(is_early_ioremap_ptep(ptep) && pfn != (pgt_buf_end - 1)))
pte = pte_wrprotect(pte);
--
1.7.2.3
next prev parent reply other threads:[~2011-04-12 11:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 11:16 [PATCH 0/4] xen: critical bug fixes for 2.6.39-rc3 Stefano Stabellini
2011-04-12 11:19 ` stefano.stabellini [this message]
2011-04-12 16:47 ` [PATCH 1/4] xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf_top Konrad Rzeszutek Wilk
2011-04-13 10:24 ` Stefano Stabellini
2011-04-12 11:19 ` [PATCH 2/4] x86,xen: introduce x86_init.mapping.pagetable_reserve stefano.stabellini
2011-04-12 11:50 ` [Xen-devel] [PATCH 2/4] x86, xen: " Jan Beulich
2011-04-12 17:41 ` Stefano Stabellini
2011-04-12 17:40 ` [PATCH 2/4] x86,xen: " Yinghai Lu
2011-04-13 10:35 ` Stefano Stabellini
2011-04-13 18:28 ` H. Peter Anvin
2011-04-14 11:05 ` Stefano Stabellini
2011-04-13 18:03 ` Konrad Rzeszutek Wilk
2011-04-13 18:35 ` [PATCH 2/4] x86, xen: " H. Peter Anvin
2011-04-13 20:19 ` [PATCH 2/4] x86,xen: " Konrad Rzeszutek Wilk
2011-04-13 18:26 ` H. Peter Anvin
2011-04-14 11:30 ` Stefano Stabellini
2011-04-14 14:49 ` Stefano Stabellini
2011-04-14 14:52 ` H. Peter Anvin
2011-04-14 18:09 ` Stefano Stabellini
2011-04-18 14:09 ` Stefano Stabellini
2011-04-18 14:42 ` H. Peter Anvin
2011-04-18 17:21 ` Stefano Stabellini
2011-04-20 16:50 ` Jeremy Fitzhardinge
2011-04-12 11:19 ` [PATCH 3/4] xen: more debugging in the e820 parsing stefano.stabellini
2011-04-12 16:39 ` Konrad Rzeszutek Wilk
2011-04-13 10:24 ` Stefano Stabellini
2011-04-13 17:54 ` Konrad Rzeszutek Wilk
2011-04-14 10:35 ` Stefano Stabellini
2011-04-12 11:19 ` [PATCH 4/4] xen: do not create the extra e820 region at an addr lower than 4G stefano.stabellini
2011-04-12 16:48 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302607192-21355-1-git-send-email-stefano.stabellini@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=hpa@linux.intel.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xen-devel@lists.xensource.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).