From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, stefano.stabellini@eu.citrix.com,
yinghai@kernel.org, hpa@zytor.com
Cc: xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH 2/2] xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf_top
Date: Mon, 2 May 2011 13:22:22 -0400 [thread overview]
Message-ID: <1304356942-17656-3-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1304356942-17656-1-git-send-email-konrad.wilk@oracle.com>
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
mask_rw_pte is currently checking if a pfn is a pagetable page if it
falls in the range pgt_buf_start - pgt_buf_end but that is incorrect
because pgt_buf_end is a moving target: pgt_buf_top is the real
boundary.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/xen/mmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 1bca25f..55c965b 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -1616,7 +1616,7 @@ static __init pte_t mask_rw_pte(pte_t *ptep, pte_t pte)
* it is RO.
*/
if (((!is_early_ioremap_ptep(ptep) &&
- pfn >= pgt_buf_start && pfn < pgt_buf_end)) ||
+ pfn >= pgt_buf_start && pfn < pgt_buf_top)) ||
(is_early_ioremap_ptep(ptep) && pfn != (pgt_buf_end - 1)))
pte = pte_wrprotect(pte);
--
1.7.1
next prev parent reply other threads:[~2011-05-02 17:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 17:22 [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high' Konrad Rzeszutek Wilk
2011-05-02 17:22 ` [PATCH 1/2] xen/mmu: Add workaround "x86-64, mm: Put early page table high" Konrad Rzeszutek Wilk
2011-05-03 0:55 ` Daniel Kiper
2011-05-03 15:12 ` Konrad Rzeszutek Wilk
2011-05-03 19:51 ` Daniel Kiper
2011-05-04 18:59 ` Daniel Kiper
2011-05-04 19:33 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-05-05 11:34 ` Daniel Kiper
2011-05-05 12:55 ` Stefano Stabellini
2011-05-05 14:01 ` Konrad Rzeszutek Wilk
2011-05-05 14:06 ` Stefano Stabellini
2011-05-09 7:06 ` Daniel Kiper
2011-05-03 13:20 ` Stefano Stabellini
2011-05-03 15:27 ` Konrad Rzeszutek Wilk
2011-05-02 17:22 ` Konrad Rzeszutek Wilk [this message]
2011-05-02 17:31 ` [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high' H. Peter Anvin
2011-05-02 18:08 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-05-02 18:33 ` H. Peter Anvin
2011-05-02 19:34 ` Konrad Rzeszutek Wilk
2011-05-02 19:59 ` [Xen-devel] " H. Peter Anvin
2011-05-02 20:07 ` Konrad Rzeszutek Wilk
2011-05-02 20:16 ` Yinghai Lu
2011-05-05 16:28 ` Re: [PATCH] Two patches fixing regression introduced by 'x86-64, mm: Put early page table high' - does not work Konrad Rzeszutek Wilk
2011-05-05 18:45 ` [Xen-devel] " Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304356942-17656-3-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).