From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH 4/4] mm: Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM Date: Tue, 03 May 2011 09:10:12 -0700 Message-ID: <1304439012.30823.62.camel@nimitz> References: <20110502212226.GE4623@router-fw-old.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110502212226.GE4623@router-fw-old.local.net-space.pl> Sender: owner-linux-mm@kvack.org To: Daniel Kiper Cc: ian.campbell@citrix.com, akpm@linux-foundation.org, andi.kleen@intel.com, haicheng.li@linux.intel.com, fengguang.wu@intel.com, jeremy@goop.org, konrad.wilk@oracle.com, dan.magenheimer@oracle.com, v.tolstov@selfip.ru, pasik@iki.fi, wdauchy@gmail.com, rientjes@google.com, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-Id: xen-devel@lists.xenproject.org On Mon, 2011-05-02 at 23:22 +0200, Daniel Kiper wrote: > Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM. > > Signed-off-by: Daniel Kiper I'd like if this was a bit easier to verify that it didn't break anything. Basically, we should probably limit direct use of PFN_SECTION_SHIFT to inside #ifdefs in headers. But, if something is truly using this today, it's probably broken. It's easy enough to work around if someone hits it, I guess. Acked-by: Dave Hansen -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org