From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: [PATCH 1/3] xen-blkfront: fix data size for xenbus_gather in blkfront_connect Date: Thu, 5 May 2011 14:55:19 -0400 Message-ID: <1304621721-22608-2-git-send-email-konrad.wilk@oracle.com> References: <1304621721-22608-1-git-send-email-konrad.wilk@oracle.com> Return-path: In-Reply-To: <1304621721-22608-1-git-send-email-konrad.wilk@oracle.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org, jaxboe@fusionio.com, xen-devel@lists.xensource.com Cc: daniel.stodden@citrix.com, stefano.stabellini@eu.citrix.com, Ian.Campbell@citrix.com, Marek Marczykowski , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org From: Marek Marczykowski barrier variable is int, not long. This overflow caused another variable override: "err" (in PV code) and "binfo" (in xenlinux code - drivers/xen/blkfront/blkfront.c). The later caused incorrect device flags (RO/removable etc). Signed-off-by: Marek Marczykowski Acked-by: Ian Campbell [v1: Changed title] Signed-off-by: Konrad Rzeszutek Wilk --- drivers/block/xen-blkfront.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 9cb8668..2075981 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1141,7 +1141,7 @@ static void blkfront_connect(struct blkfront_info *info) } err = xenbus_gather(XBT_NIL, info->xbdev->otherend, - "feature-barrier", "%lu", &barrier, + "feature-barrier", "%d", &barrier, NULL); /* -- 1.7.4.1