xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: Rajagopalan <rshriram@cs.ubc.ca>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Keir Fraser <keir.xen@gmail.com>,
	Shriram
Subject: Re: [PATCH] Fix save.py bug
Date: Fri, 13 May 2011 15:36:18 +0100	[thread overview]
Message-ID: <1305297378.31488.132.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E2076373075@shsmsx502.ccr.corp.intel.com>

Adding Remus maintainer. You can consult the MAINTAINERS file at the top
level to fix this.

On Fri, 2011-05-13 at 15:26 +0100, Liu, Jinsong wrote:
> I don't know python well, but when I compile at my platform, compile error as:
> 
> 
> =======================
> ...
> Parsing libxl.idl
> cmp: _libxl_paths.h.tmp: No such file or directory
> cmp: _libxl_paths.h: No such file or directory
> cmp: xen/util/path.py: No such file or directory
> Parsing /otc/source/vtd/xen-unstable/tools/python/../../tools/libxl/libxl.idl
>   File "/usr/lib64/python2.4/site-packages/xen/remus/save.py", line 169
>     finally:
>           ^
> SyntaxError: invalid syntax
> ...
> 
> ======================
> 
> 
> This kind of compile error introduced from c/s 23195. 
> This patch revert it.

That seems rather extreme in the first instance.

>From a quick google It seems that python 2.4 did not properly support
the "try: ... except: ... finally: ... " syntax. It appears that as a
workaround one can do
	try:
		try:
			...
		except:
			...
	finally:
		...

But I didn't try this myself.

Ian.

  reply	other threads:[~2011-05-13 14:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13 14:26 [PATCH] Fix save.py bug Liu, Jinsong
2011-05-13 14:36 ` Ian Campbell [this message]
2011-05-13 17:33   ` Liu, Jinsong
2011-05-17  1:58     ` Shriram Rajagopalan
  -- strict thread matches above, loose matches on Subject: below --
2011-05-18  8:30 Liu, Jinsong
2011-05-18 13:00 ` Shriram Rajagopalan
2011-05-19 12:05   ` Liu, Jinsong
2011-05-20 16:54   ` Ian Jackson
2011-05-21  3:30     ` Liu, Jinsong
2011-05-21 11:29       ` Shriram Rajagopalan
2011-05-23  8:22     ` Liu, Jinsong
2011-05-24 15:13       ` Ian Jackson
2011-05-25  2:32         ` Liu, Jinsong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305297378.31488.132.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=jinsong.liu@intel.com \
    --cc=keir.xen@gmail.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).