Patch and question about init.d

Patch and question about init.d

[Fantu]

I made a patch based on staging/xen-unstable.hg, I hope it is correct, i add
in post below, add runlevel 2 to default-start on init where missed.
I have also some question:
xen-watchdog works only with xend  and need it or not? if not xend must be
moved from required to should if I'm not mistaken
(http://refspecs.freestandards.org/LSB_3.2.0/LSB-Core-generic/LSB-Core-generic/initscrcomconv.html).
Same question also about xendomain, is possible execute also with xl only?
if yes xend must be moved from required to should and xenstored add to
required.
If xendomains now is not working with xl only should be done, xendomains do
some essentials functions (for example autostart of domU or restore if
exists savefile)
If you give me your answer do I patch and post it here, patch must be all
based on staging/xen-unstable and backports to staging/xen-4.1-testing.hg
and staging/xen-4.0-testing.hg if necessary, right?

--
View this message in context: http://xen.1045712.n5.nabble.com/Patch-and-question-about-init-d-tp4421670p4421670.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: Patch and question about init.d

[Fantu]

# HG changeset patch
# User Fabio Fantoni
# Date 1306230538 -7200
# Branch fabio
# Node ID 79341a653633ffde213dfa7d071b677d419707bb
# Parent  d74585e5dc9f33f6d840718c5afa8fe002107fc7
tools/hotplug/Linux: start all xen daemons in runlevel 2

Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it> 

diff -r d74585e5dc9f -r 79341a653633 tools/hotplug/Linux/init.d/xen-watchdog
--- a/tools/hotplug/Linux/init.d/xen-watchdog	Tue May 24 09:30:51 2011 +0100
+++ b/tools/hotplug/Linux/init.d/xen-watchdog	Tue May 24 11:48:58 2011 +0200
@@ -10,8 +10,8 @@
 # Should-Start:      $syslog $remote_fs
 # Required-Stop:     xend
 # Should-Stop:       $syslog $remote_fs
-# Default-Start:     3 4 5
-# Default-Stop:      0 1 2 6
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Short-Description: Start/stop xen-watchdog
 # Description:       Run domain watchdog daemon.
 ### END INIT INFO
diff -r d74585e5dc9f -r 79341a653633 tools/hotplug/Linux/init.d/xend
--- a/tools/hotplug/Linux/init.d/xend	Tue May 24 09:30:51 2011 +0100
+++ b/tools/hotplug/Linux/init.d/xend	Tue May 24 11:48:58 2011 +0200
@@ -12,8 +12,8 @@
 # Should-Start:
 # Required-Stop:     $syslog $remote_fs xenstored
 # Should-Stop:
-# Default-Start:     3 4 5
-# Default-Stop:      0 1 2 6
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Short-Description: Start/stop xend
 # Description:       Starts and stops the Xen control daemon.
 ### END INIT INFO
diff -r d74585e5dc9f -r 79341a653633 tools/hotplug/Linux/init.d/xendomains
--- a/tools/hotplug/Linux/init.d/xendomains	Tue May 24 09:30:51 2011 +0100
+++ b/tools/hotplug/Linux/init.d/xendomains	Tue May 24 11:48:58 2011 +0200
@@ -20,8 +20,8 @@
 # Should-Start:
 # Required-Stop:     $syslog $remote_fs xend
 # Should-Stop:
-# Default-Start:     3 4 5
-# Default-Stop:      0 1 2 6
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Short-Description: Start/stop secondary xen domains
 # Description:       Start / stop domains automatically when domain 0 
 #                    boots / shuts down.

--
View this message in context: http://xen.1045712.n5.nabble.com/Patch-and-question-about-init-d-tp4421670p4421675.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: Patch and question about init.d

[Ian Jackson]

Fantu writes ("[Xen-devel] Re: Patch and question about init.d"):
> tools/hotplug/Linux: start all xen daemons in runlevel 2

I'm tempted to apply this but I'd like to solicit opinions.

Ian.

Re: Re: Patch and question about init.d

[Ian Campbell]

On Tue, 2011-05-24 at 17:47 +0100, Ian Jackson wrote:
> Fantu writes ("[Xen-devel] Re: Patch and question about init.d"):
> > tools/hotplug/Linux: start all xen daemons in runlevel 2
> 
> I'm tempted to apply this but I'd like to solicit opinions.

Since I added the runlevel 2 to the xencommons initscript I feel
qualified to give one...

IMHO it makes sense to start all the services we provide in the same set
of runlevels, whatever those might be, by default. 

Further, I think having everything started in run-levels 2, 3, 4 and 5
by default is the correct default so this change is the correct one.

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian.

Re: Patch and question about init.d

[Fantu]

About xendomains and xenwatchdog, probably I didn't wrote the right
questions, I try to write them better.
Xenwatchdog works also with xl only or requires also xend?
Xendomains works also with xl only or requires also xend? Since xendomains
has essential functions I think that it should also work in xl only
According to your replies I'll post the patch with the modified lsb headers
Thanks for any reply

--
View this message in context: http://xen.1045712.n5.nabble.com/Patch-and-question-about-init-d-tp4421670p4424792.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: Re: Patch and question about init.d

[Ian Campbell]

On Wed, 2011-05-25 at 10:53 +0100, Fantu wrote:
> About xendomains and xenwatchdog, probably I didn't wrote the right
> questions, I try to write them better.
> Xenwatchdog works also with xl only or requires also xend?

I don't see anything which requires one or the other, it appears to be
completely toolstack independent. Best evidence would be to try it
though.

> Xendomains works also with xl only or requires also xend?

It is supposed to work with both but evidently the xl support is buggy.
Please see Carsten Schiers' recent posts to this list.

Ian.
>  Since xendomains
> has essential functions I think that it should also work in xl only
> According to your replies I'll post the patch with the modified lsb headers
> Thanks for any reply
> 
> --
> View this message in context: http://xen.1045712.n5.nabble.com/Patch-and-question-about-init-d-tp4421670p4424792.html
> Sent from the Xen - Dev mailing list archive at Nabble.com.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: Re: Patch and question about init.d

[Konrad Rzeszutek Wilk]

On Wed, May 25, 2011 at 11:10:47AM +0100, Ian Campbell wrote:
> On Wed, 2011-05-25 at 10:53 +0100, Fantu wrote:
> > About xendomains and xenwatchdog, probably I didn't wrote the right
> > questions, I try to write them better.
> > Xenwatchdog works also with xl only or requires also xend?
> 
> I don't see anything which requires one or the other, it appears to be
> completely toolstack independent. Best evidence would be to try it
> though.

Do we actually need xenwatchdog anymore? Jan's Xen Watchdog driver
uses the watchdog API, so if one uses the 'watchdog' service it should
start automatically?

Re: Re: Patch and question about init.d

[Ian Campbell]

On Wed, 2011-05-25 at 14:03 +0100, Konrad Rzeszutek Wilk wrote:
> On Wed, May 25, 2011 at 11:10:47AM +0100, Ian Campbell wrote:
> > On Wed, 2011-05-25 at 10:53 +0100, Fantu wrote:
> > > About xendomains and xenwatchdog, probably I didn't wrote the right
> > > questions, I try to write them better.
> > > Xenwatchdog works also with xl only or requires also xend?
> > 
> > I don't see anything which requires one or the other, it appears to be
> > completely toolstack independent. Best evidence would be to try it
> > though.
> 
> Do we actually need xenwatchdog anymore? Jan's Xen Watchdog driver
> uses the watchdog API, so if one uses the 'watchdog' service it should
> start automatically?

People on older or non-Linux kernels still need xenwatchdogd, but for
modern Linux kernels we should probably recommend using the standard
watchdog tools via Jan's driver. Do any other guest OSes have a proper
watchdog driver?

Ian.

Re: Re: Patch and question about init.d

[Olaf Hering]

On Wed, May 25, Ian Campbell wrote:

> Further, I think having everything started in run-levels 2, 3, 4 and 5
> by default is the correct default so this change is the correct one.

Runlevel 4 is for the local sysadmin, it should not be part of the
listed runlevels. Maybe that part can be changed as well when the code
is touched now.

Olaf

Re: Re: Patch and question about init.d

[Ian Campbell]

On Wed, 2011-05-25 at 11:13 +0100, Olaf Hering wrote:
> On Wed, May 25, Ian Campbell wrote:
> 
> > Further, I think having everything started in run-levels 2, 3, 4 and 5
> > by default is the correct default so this change is the correct one.
> 
> Runlevel 4 is for the local sysadmin, it should not be part of the
> listed runlevels.

Any meaning attached to a specific runlevels between 2-5 is distro
specific. 0, 1, and 6 have reasonably consistent meanings across distros
(perhaps something somewhere specifies this?).

Under Debian for example all run-levels 2-5 are deemed to be the same
with any differences being up to the admin.

I don't think we can easily resolve this disparity in the initscripts
shipped with Xen so I think the choices boil down to either all
runlevels or none, and I think all is the least surprising / most
useful.

Ian.

>  Maybe that part can be changed as well when the code
> is touched now.
> 
> Olaf
> 

Re: Re: Patch and question about init.d

[Ian Jackson]

Ian Campbell writes ("Re: [Xen-devel] Re: Patch and question about init.d"):
> Any meaning attached to a specific runlevels between 2-5 is distro
> specific. 0, 1, and 6 have reasonably consistent meanings across distros
> (perhaps something somewhere specifies this?).
> 
> Under Debian for example all run-levels 2-5 are deemed to be the same
> with any differences being up to the admin.
> 
> I don't think we can easily resolve this disparity in the initscripts
> shipped with Xen so I think the choices boil down to either all
> runlevels or none, and I think all is the least surprising / most
> useful.

I agree with Ian.  I have committed the original version of the
patch.  Thanks.

Ian.