From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] xen/x86: Add -Wnested-externs to CFLAGS
Date: Thu, 26 May 2011 17:52:12 +0100
Message-ID: <1306428732.23577.8.camel@dagon.hellion.org.uk>
References: <73ba1d95d1ec59246e2f.1306427571@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <73ba1d95d1ec59246e2f.1306427571@whitby.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tim Deegan <Tim.Deegan@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2011-05-26 at 17:32 +0100, Tim Deegan wrote:
> # HG changeset patch
> # User Tim Deegan <Tim.Deegan@citrix.com>
> # Date 1306427536 -3600
> # Node ID 73ba1d95d1ec59246e2f0a8e8a1136cd5f9d98c2
> # Parent  69fe4b8a7c0961070a626cb473d19a0770db663a
> xen/x86: Add -Wnested-externs to CFLAGS
> 
> This will catch any new extern declarations that happen actually
> inside function bodies.  Unfortunately there's no equivalent
> warning for extern declarations at rootl level in .c files.
> 
> diff -r 69fe4b8a7c09 -r 73ba1d95d1ec xen/arch/x86/Rules.mk
> --- a/xen/arch/x86/Rules.mk	Thu May 26 17:17:43 2011 +0100
> +++ b/xen/arch/x86/Rules.mk	Thu May 26 17:32:16 2011 +0100
> @@ -27,6 +27,7 @@ CFLAGS += -I$(BASEDIR)/include/asm-x86/m
>  CFLAGS += -msoft-float
>  
>  $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
> +$(call cc-option-add,CFLAGS,CC,-Wnested-externs)
                   ^ missing s?

>  
>  ifeq ($(supervisor_mode_kernel),y)
>  CFLAGS += -DCONFIG_X86_SUPERVISOR_MODE_KERNEL=1
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel