From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Tim Deegan <Tim.Deegan@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xen/x86: Add -Wnested-externs to CFLAGS
Date: Thu, 26 May 2011 19:26:40 +0100 [thread overview]
Message-ID: <1306434400.23577.9.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20110526173029.GA30253@whitby.uk.xensource.com>
On Thu, 2011-05-26 at 18:30 +0100, Tim Deegan wrote:
> At 17:52 +0100 on 26 May (1306432332), Ian Campbell wrote:
> > On Thu, 2011-05-26 at 17:32 +0100, Tim Deegan wrote:
> > > # HG changeset patch
> > > # User Tim Deegan <Tim.Deegan@citrix.com>
> > > # Date 1306427536 -3600
> > > # Node ID 73ba1d95d1ec59246e2f0a8e8a1136cd5f9d98c2
> > > # Parent 69fe4b8a7c0961070a626cb473d19a0770db663a
> > > xen/x86: Add -Wnested-externs to CFLAGS
> > >
> > > This will catch any new extern declarations that happen actually
> > > inside function bodies. Unfortunately there's no equivalent
> > > warning for extern declarations at rootl level in .c files.
> > >
> > > diff -r 69fe4b8a7c09 -r 73ba1d95d1ec xen/arch/x86/Rules.mk
> > > --- a/xen/arch/x86/Rules.mk Thu May 26 17:17:43 2011 +0100
> > > +++ b/xen/arch/x86/Rules.mk Thu May 26 17:32:16 2011 +0100
> > > @@ -27,6 +27,7 @@ CFLAGS += -I$(BASEDIR)/include/asm-x86/m
> > > CFLAGS += -msoft-float
> > >
> > > $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
> > > +$(call cc-option-add,CFLAGS,CC,-Wnested-externs)
> > ^ missing s?
>
> No; the _s_ version is a wrapper that processes a list.
Ah, nevermind then.
Ian.
>
>
> Tim.
>
> > >
> > > ifeq ($(supervisor_mode_kernel),y)
> > > CFLAGS += -DCONFIG_X86_SUPERVISOR_MODE_KERNEL=1
> > >
> > > _______________________________________________
> > > Xen-devel mailing list
> > > Xen-devel@lists.xensource.com
> > > http://lists.xensource.com/xen-devel
> >
> >
>
prev parent reply other threads:[~2011-05-26 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 16:32 [PATCH] xen/x86: Add -Wnested-externs to CFLAGS Tim Deegan
2011-05-26 16:52 ` Ian Campbell
2011-05-26 17:30 ` Tim Deegan
2011-05-26 18:26 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306434400.23577.9.camel@dagon.hellion.org.uk \
--to=ian.campbell@eu.citrix.com \
--cc=Tim.Deegan@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).