* [PATCH] xen/x86: Add -Wnested-externs to CFLAGS
@ 2011-05-26 16:32 Tim Deegan
2011-05-26 16:52 ` Ian Campbell
0 siblings, 1 reply; 4+ messages in thread
From: Tim Deegan @ 2011-05-26 16:32 UTC (permalink / raw)
To: xen-devel
# HG changeset patch
# User Tim Deegan <Tim.Deegan@citrix.com>
# Date 1306427536 -3600
# Node ID 73ba1d95d1ec59246e2f0a8e8a1136cd5f9d98c2
# Parent 69fe4b8a7c0961070a626cb473d19a0770db663a
xen/x86: Add -Wnested-externs to CFLAGS
This will catch any new extern declarations that happen actually
inside function bodies. Unfortunately there's no equivalent
warning for extern declarations at rootl level in .c files.
diff -r 69fe4b8a7c09 -r 73ba1d95d1ec xen/arch/x86/Rules.mk
--- a/xen/arch/x86/Rules.mk Thu May 26 17:17:43 2011 +0100
+++ b/xen/arch/x86/Rules.mk Thu May 26 17:32:16 2011 +0100
@@ -27,6 +27,7 @@ CFLAGS += -I$(BASEDIR)/include/asm-x86/m
CFLAGS += -msoft-float
$(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
+$(call cc-option-add,CFLAGS,CC,-Wnested-externs)
ifeq ($(supervisor_mode_kernel),y)
CFLAGS += -DCONFIG_X86_SUPERVISOR_MODE_KERNEL=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/x86: Add -Wnested-externs to CFLAGS
2011-05-26 16:32 [PATCH] xen/x86: Add -Wnested-externs to CFLAGS Tim Deegan
@ 2011-05-26 16:52 ` Ian Campbell
2011-05-26 17:30 ` Tim Deegan
0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2011-05-26 16:52 UTC (permalink / raw)
To: Tim Deegan; +Cc: xen-devel@lists.xensource.com
On Thu, 2011-05-26 at 17:32 +0100, Tim Deegan wrote:
> # HG changeset patch
> # User Tim Deegan <Tim.Deegan@citrix.com>
> # Date 1306427536 -3600
> # Node ID 73ba1d95d1ec59246e2f0a8e8a1136cd5f9d98c2
> # Parent 69fe4b8a7c0961070a626cb473d19a0770db663a
> xen/x86: Add -Wnested-externs to CFLAGS
>
> This will catch any new extern declarations that happen actually
> inside function bodies. Unfortunately there's no equivalent
> warning for extern declarations at rootl level in .c files.
>
> diff -r 69fe4b8a7c09 -r 73ba1d95d1ec xen/arch/x86/Rules.mk
> --- a/xen/arch/x86/Rules.mk Thu May 26 17:17:43 2011 +0100
> +++ b/xen/arch/x86/Rules.mk Thu May 26 17:32:16 2011 +0100
> @@ -27,6 +27,7 @@ CFLAGS += -I$(BASEDIR)/include/asm-x86/m
> CFLAGS += -msoft-float
>
> $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
> +$(call cc-option-add,CFLAGS,CC,-Wnested-externs)
^ missing s?
>
> ifeq ($(supervisor_mode_kernel),y)
> CFLAGS += -DCONFIG_X86_SUPERVISOR_MODE_KERNEL=1
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xen/x86: Add -Wnested-externs to CFLAGS
2011-05-26 16:52 ` Ian Campbell
@ 2011-05-26 17:30 ` Tim Deegan
2011-05-26 18:26 ` Ian Campbell
0 siblings, 1 reply; 4+ messages in thread
From: Tim Deegan @ 2011-05-26 17:30 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel@lists.xensource.com
At 17:52 +0100 on 26 May (1306432332), Ian Campbell wrote:
> On Thu, 2011-05-26 at 17:32 +0100, Tim Deegan wrote:
> > # HG changeset patch
> > # User Tim Deegan <Tim.Deegan@citrix.com>
> > # Date 1306427536 -3600
> > # Node ID 73ba1d95d1ec59246e2f0a8e8a1136cd5f9d98c2
> > # Parent 69fe4b8a7c0961070a626cb473d19a0770db663a
> > xen/x86: Add -Wnested-externs to CFLAGS
> >
> > This will catch any new extern declarations that happen actually
> > inside function bodies. Unfortunately there's no equivalent
> > warning for extern declarations at rootl level in .c files.
> >
> > diff -r 69fe4b8a7c09 -r 73ba1d95d1ec xen/arch/x86/Rules.mk
> > --- a/xen/arch/x86/Rules.mk Thu May 26 17:17:43 2011 +0100
> > +++ b/xen/arch/x86/Rules.mk Thu May 26 17:32:16 2011 +0100
> > @@ -27,6 +27,7 @@ CFLAGS += -I$(BASEDIR)/include/asm-x86/m
> > CFLAGS += -msoft-float
> >
> > $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
> > +$(call cc-option-add,CFLAGS,CC,-Wnested-externs)
> ^ missing s?
No; the _s_ version is a wrapper that processes a list.
Tim.
> >
> > ifeq ($(supervisor_mode_kernel),y)
> > CFLAGS += -DCONFIG_X86_SUPERVISOR_MODE_KERNEL=1
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
>
>
--
Tim Deegan <Tim.Deegan@citrix.com>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/x86: Add -Wnested-externs to CFLAGS
2011-05-26 17:30 ` Tim Deegan
@ 2011-05-26 18:26 ` Ian Campbell
0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2011-05-26 18:26 UTC (permalink / raw)
To: Tim Deegan; +Cc: xen-devel@lists.xensource.com
On Thu, 2011-05-26 at 18:30 +0100, Tim Deegan wrote:
> At 17:52 +0100 on 26 May (1306432332), Ian Campbell wrote:
> > On Thu, 2011-05-26 at 17:32 +0100, Tim Deegan wrote:
> > > # HG changeset patch
> > > # User Tim Deegan <Tim.Deegan@citrix.com>
> > > # Date 1306427536 -3600
> > > # Node ID 73ba1d95d1ec59246e2f0a8e8a1136cd5f9d98c2
> > > # Parent 69fe4b8a7c0961070a626cb473d19a0770db663a
> > > xen/x86: Add -Wnested-externs to CFLAGS
> > >
> > > This will catch any new extern declarations that happen actually
> > > inside function bodies. Unfortunately there's no equivalent
> > > warning for extern declarations at rootl level in .c files.
> > >
> > > diff -r 69fe4b8a7c09 -r 73ba1d95d1ec xen/arch/x86/Rules.mk
> > > --- a/xen/arch/x86/Rules.mk Thu May 26 17:17:43 2011 +0100
> > > +++ b/xen/arch/x86/Rules.mk Thu May 26 17:32:16 2011 +0100
> > > @@ -27,6 +27,7 @@ CFLAGS += -I$(BASEDIR)/include/asm-x86/m
> > > CFLAGS += -msoft-float
> > >
> > > $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
> > > +$(call cc-option-add,CFLAGS,CC,-Wnested-externs)
> > ^ missing s?
>
> No; the _s_ version is a wrapper that processes a list.
Ah, nevermind then.
Ian.
>
>
> Tim.
>
> > >
> > > ifeq ($(supervisor_mode_kernel),y)
> > > CFLAGS += -DCONFIG_X86_SUPERVISOR_MODE_KERNEL=1
> > >
> > > _______________________________________________
> > > Xen-devel mailing list
> > > Xen-devel@lists.xensource.com
> > > http://lists.xensource.com/xen-devel
> >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-26 18:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-26 16:32 [PATCH] xen/x86: Add -Wnested-externs to CFLAGS Tim Deegan
2011-05-26 16:52 ` Ian Campbell
2011-05-26 17:30 ` Tim Deegan
2011-05-26 18:26 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).