[PATCH 2 of 2] xendomains: remove unnecessary dependency of xend

[PATCH 2 of 2] xendomains: remove unnecessary dependency of xend

[Carsten Schiers]

[-- Attachment #1.1: Type: text/plain, Size: 797 bytes --]

As xl compatibility seems now mature enough to allow xm replacement in 

/etc/init.d/xendomains, eliminate the dependency.

 

Signed-off-by: Carsten Schiers <carsten@schiers.de>

 

diff -r 37c77bacb52a tools/hotplug/Linux/init.d/xendomains

--- a/tools/hotplug/Linux/init.d/xendomains    Mon May 23 17:38:28 2011
+0100

+++ b/tools/hotplug/Linux/init.d/xendomains    Thu May 26 20:17:15 2011
+0200

@@ -16,9 +16,9 @@

#

### BEGIN INIT INFO

# Provides:          xendomains

-# Required-Start:    $syslog $remote_fs xend

+# Required-Start:    $syslog $remote_fs

# Should-Start:

-# Required-Stop:     $syslog $remote_fs xend

+# Required-Stop:     $syslog $remote_fs 

 # Should-Stop:

# Default-Start:     3 4 5

# Default-Stop:      0 1 2 6

 



[-- Attachment #1.2: Type: text/html, Size: 4972 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH 2 of 2] xendomains: remove unnecessary dependency of xend

[Fantu]

is not correct, xend must be moved to shoud for correct start/stop if is in
active service and xenstored must be add in require for correct start/stop
in xl only (without xend)

# HG changeset patch
# User Fabio Fantoni
# Date 1306440094 -7200
# Branch fabio
# Node ID a04915fc5af828e6b41326e8d601bb94435a13b9
# Parent  3bfc3d4e4792831a80821143a06d8f4b25a9fb43
tools/hotplug/Linux/init.d/xendomains: modified LBS header:
- move xend to should, is not require must if present must be in correct
start/stop order
- add xenstored to requires because must be in correct start/stop order in
xl only

Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>

diff -r 3bfc3d4e4792 -r a04915fc5af8 tools/hotplug/Linux/init.d/xendomains
--- a/tools/hotplug/Linux/init.d/xendomains	Tue May 24 14:30:03 2011 +0200
+++ b/tools/hotplug/Linux/init.d/xendomains	Thu May 26 22:01:34 2011 +0200
@@ -16,10 +16,10 @@
 #
 ### BEGIN INIT INFO
 # Provides:          xendomains
-# Required-Start:    $syslog $remote_fs xend
-# Should-Start:
-# Required-Stop:     $syslog $remote_fs xend
-# Should-Stop:
+# Required-Start:    $syslog $remote_fs xenstored
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs xenstored
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop secondary xen domains

--
View this message in context: http://xen.1045712.n5.nabble.com/PATCH-2-of-2-xendomains-remove-unnecessary-dependency-of-xend-tp4429591p4429914.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: [PATCH 2 of 2] xendomains: remove unnecessary dependency of xend

[Ian Jackson]

Fantu writes ("[Xen-devel] Re: [PATCH 2 of 2] xendomains: remove unnecessary dependency of xend"):
> is not correct, xend must be moved to shoud for correct start/stop if is in
> active service and xenstored must be add in require for correct start/stop
> in xl only (without xend)

The existing xend hotplug script requires xend so this looks OK as far
as it goes but surely xenconsoled should be listed too ?

Ian.

Re: [PATCH 2 of 2] xendomains: remove unnecessary dependency of xend

[Fantu]

xenstored and xenconsoled are in same init script (xencommons)

--
View this message in context: http://xen.1045712.n5.nabble.com/PATCH-2-of-2-xendomains-remove-unnecessary-dependency-of-xend-tp4429591p4450241.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: Re: [PATCH 2 of 2] xendomains: remove unnecessary dependency of xend

[Ian Campbell]

On Fri, 2011-06-03 at 06:53 +0100, Fantu wrote:
> xenstored and xenconsoled are in same init script (xencommons)

Sure, but if we are going to refer to one of them by service name
instead of initscript name we should logically refer to both of them
that way. Otherwise what happens if someone splits the script in two?

Ian.

Re: [PATCH 2 of 2] xendomains: remove unnecessary dependency of xend

[Fantu]

# HG changeset patch
# User Fabio Fantoni
# Date 1307094826 -7200
# Node ID 7fe9e9a990cc42632352f569a24e8bdfad6eccd8
# Parent  0791661a32d8eba917c87feacf2c955b85521ad1
tools/hotplug/Linux/init.d/:
Improved LSB headers
xendomains service now working also without xend service

Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>

diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xen-watchdog
--- a/tools/hotplug/Linux/init.d/xen-watchdog	Thu Jun 02 18:46:35 2011 +0100
+++ b/tools/hotplug/Linux/init.d/xen-watchdog	Fri Jun 03 11:53:46 2011 +0200
@@ -6,10 +6,10 @@
 # description: Run domain watchdog daemon
 ### BEGIN INIT INFO
 # Provides:          xen-watchdog
-# Required-Start:    xend
-# Should-Start:      $syslog $remote_fs
-# Required-Stop:     xend
-# Should-Stop:       $syslog $remote_fs
+# Required-Start:    $syslog $remote_fs
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop xen-watchdog
diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xend
--- a/tools/hotplug/Linux/init.d/xend	Thu Jun 02 18:46:35 2011 +0100
+++ b/tools/hotplug/Linux/init.d/xend	Fri Jun 03 11:53:46 2011 +0200
@@ -8,9 +8,9 @@
 # description: Starts and stops the Xen control daemon.
 ### BEGIN INIT INFO
 # Provides:          xend
-# Required-Start:    $syslog $remote_fs xenstored
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled
 # Should-Start:
-# Required-Stop:     $syslog $remote_fs xenstored
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
 # Should-Stop:
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xendomains
--- a/tools/hotplug/Linux/init.d/xendomains	Thu Jun 02 18:46:35 2011 +0100
+++ b/tools/hotplug/Linux/init.d/xendomains	Fri Jun 03 11:53:46 2011 +0200
@@ -16,10 +16,10 @@
 #
 ### BEGIN INIT INFO
 # Provides:          xendomains
-# Required-Start:    $syslog $remote_fs xend
-# Should-Start:
-# Required-Stop:     $syslog $remote_fs xend
-# Should-Stop:
+# Required-Start:    $syslog $remote_fs xenstored xenconsoled
+# Should-Start:      xend
+# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
+# Should-Stop:       xend
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start/stop secondary xen domains


--
View this message in context: http://xen.1045712.n5.nabble.com/PATCH-2-of-2-xendomains-remove-unnecessary-dependency-of-xend-tp4429591p4450722.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: Re: [PATCH 2 of 2] xendomains: remove unnecessary dependency of xend

[Ian Campbell]

On Fri, 2011-06-03 at 11:22 +0100, Fantu wrote:
> # HG changeset patch
> # User Fabio Fantoni
> # Date 1307094826 -7200
> # Node ID 7fe9e9a990cc42632352f569a24e8bdfad6eccd8
> # Parent  0791661a32d8eba917c87feacf2c955b85521ad1
> tools/hotplug/Linux/init.d/:
> Improved LSB headers
> xendomains service now working also without xend service
> 
> Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>

Your mailer is still corrupting your mail. Please fix this.

Ian.

> 
> diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xen-watchdog
> --- a/tools/hotplug/Linux/init.d/xen-watchdog	Thu Jun 02 18:46:35 2011 +0100
> +++ b/tools/hotplug/Linux/init.d/xen-watchdog	Fri Jun 03 11:53:46 2011 +0200
> @@ -6,10 +6,10 @@
>  # description: Run domain watchdog daemon
>  ### BEGIN INIT INFO
>  # Provides:          xen-watchdog
> -# Required-Start:    xend
> -# Should-Start:      $syslog $remote_fs
> -# Required-Stop:     xend
> -# Should-Stop:       $syslog $remote_fs
> +# Required-Start:    $syslog $remote_fs
> +# Should-Start:      xend
> +# Required-Stop:     $syslog $remote_fs
> +# Should-Stop:       xend
>  # Default-Start:     2 3 4 5
>  # Default-Stop:      0 1 6
>  # Short-Description: Start/stop xen-watchdog
> diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xend
> --- a/tools/hotplug/Linux/init.d/xend	Thu Jun 02 18:46:35 2011 +0100
> +++ b/tools/hotplug/Linux/init.d/xend	Fri Jun 03 11:53:46 2011 +0200
> @@ -8,9 +8,9 @@
>  # description: Starts and stops the Xen control daemon.
>  ### BEGIN INIT INFO
>  # Provides:          xend
> -# Required-Start:    $syslog $remote_fs xenstored
> +# Required-Start:    $syslog $remote_fs xenstored xenconsoled
>  # Should-Start:
> -# Required-Stop:     $syslog $remote_fs xenstored
> +# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
>  # Should-Stop:
>  # Default-Start:     2 3 4 5
>  # Default-Stop:      0 1 6
> diff -r 0791661a32d8 -r 7fe9e9a990cc tools/hotplug/Linux/init.d/xendomains
> --- a/tools/hotplug/Linux/init.d/xendomains	Thu Jun 02 18:46:35 2011 +0100
> +++ b/tools/hotplug/Linux/init.d/xendomains	Fri Jun 03 11:53:46 2011 +0200
> @@ -16,10 +16,10 @@
>  #
>  ### BEGIN INIT INFO
>  # Provides:          xendomains
> -# Required-Start:    $syslog $remote_fs xend
> -# Should-Start:
> -# Required-Stop:     $syslog $remote_fs xend
> -# Should-Stop:
> +# Required-Start:    $syslog $remote_fs xenstored xenconsoled
> +# Should-Start:      xend
> +# Required-Stop:     $syslog $remote_fs xenstored xenconsoled
> +# Should-Stop:       xend
>  # Default-Start:     2 3 4 5
>  # Default-Stop:      0 1 6
>  # Short-Description: Start/stop secondary xen domains
> 
> 
> --
> View this message in context: http://xen.1045712.n5.nabble.com/PATCH-2-of-2-xendomains-remove-unnecessary-dependency-of-xend-tp4429591p4450722.html
> Sent from the Xen - Dev mailing list archive at Nabble.com.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel