* Re: [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return [not found] ` <1306538755.2759.31.camel@bwh-desktop> @ 2011-05-28 7:35 ` Michał Mirosław [not found] ` <20110528073525.GA19033-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Michał Mirosław @ 2011-05-28 7:35 UTC (permalink / raw) To: Ben Hutchings; +Cc: David Miller, netdev, xen-devel On Sat, May 28, 2011 at 12:25:55AM +0100, Ben Hutchings wrote: > On Fri, 2011-05-27 at 18:34 +0200, Michał Mirosław wrote: > > On Fri, May 27, 2011 at 04:45:50PM +0100, Ben Hutchings wrote: > > > On Fri, 2011-05-27 at 17:28 +0200, Michał Mirosław wrote: > [...] > > > > (note: ETHTOOL_S{SG,...} are not ever going away) > > > > - causes NETIF_F_* to be an ABI > > > If feature flag numbers are not stable then what is the point of > > > /sys/class/net/<name>/features? Also, I'm not aware that features have > > > ever been renumbered in the past. > > Since no NETIF_F_* were exported earlier, I assume /sys/class/net/*/features > > is a debugging aid. What is it used for besides that? > xen-api <https://github.com/xen-org/xen-api> uses it in > scripts/InterfaceReconfigureVswitch.py. Though it doesn't seem to be > used for a particularly good reason... Look like it should use ETHTOOL_GFLAGS instead for netdev_has_vlan_accel(). Best Regards, Michał Mirosław [added Cc: xen-devel] ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20110528073525.GA19033-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>]
* Re: [Xen-devel] Re: [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return [not found] ` <20110528073525.GA19033-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> @ 2011-05-28 10:07 ` Ian Campbell [not found] ` <1306577228.23577.17.camel-ztPmHsLffjjnO4AKDKe2m+kiAK3p4hvP@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Ian Campbell @ 2011-05-28 10:07 UTC (permalink / raw) To: Michał Mirosław Cc: dev-yBygre7rU0TnMu66kgdUjQ, xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xen-api-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR, Ben Hutchings, David Miller On Sat, 2011-05-28 at 08:35 +0100, Michał Mirosław wrote: > On Sat, May 28, 2011 at 12:25:55AM +0100, Ben Hutchings wrote: > > On Fri, 2011-05-27 at 18:34 +0200, Michał Mirosław wrote: > > > On Fri, May 27, 2011 at 04:45:50PM +0100, Ben Hutchings wrote: > > > > On Fri, 2011-05-27 at 17:28 +0200, Michał Mirosław wrote: > > [...] > > > > > (note: ETHTOOL_S{SG,...} are not ever going away) > > > > > - causes NETIF_F_* to be an ABI > > > > If feature flag numbers are not stable then what is the point of > > > > /sys/class/net/<name>/features? Also, I'm not aware that features have > > > > ever been renumbered in the past. > > > Since no NETIF_F_* were exported earlier, I assume /sys/class/net/*/features > > > is a debugging aid. What is it used for besides that? > > xen-api <https://github.com/xen-org/xen-api> uses it in > > scripts/InterfaceReconfigureVswitch.py. Though it doesn't seem to be > > used for a particularly good reason... > > Look like it should use ETHTOOL_GFLAGS instead for netdev_has_vlan_accel(). > > Best Regards, > Michał Mirosław > > [added Cc: xen-devel] added Cc: xen-api list and dev@openvswitch as well. Complete thread is at http://thread.gmane.org/gmane.linux.network/195552/focus=197019 Ian. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <1306577228.23577.17.camel-ztPmHsLffjjnO4AKDKe2m+kiAK3p4hvP@public.gmane.org>]
* Re: [Xen-devel] Re: [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return [not found] ` <1306577228.23577.17.camel-ztPmHsLffjjnO4AKDKe2m+kiAK3p4hvP@public.gmane.org> @ 2011-05-28 17:31 ` Jesse Gross [not found] ` <BANLkTime8PHYe+BFELt92gg7SZ91xKvAwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Jesse Gross @ 2011-05-28 17:31 UTC (permalink / raw) To: Ian Campbell Cc: dev-yBygre7rU0TnMu66kgdUjQ, xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xen-api-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR, Ben Hutchings, Michał Mirosław, David Miller 2011/5/28 Ian Campbell <Ian.Campbell@citrix.com>: > On Sat, 2011-05-28 at 08:35 +0100, Michał Mirosław wrote: >> On Sat, May 28, 2011 at 12:25:55AM +0100, Ben Hutchings wrote: >> > On Fri, 2011-05-27 at 18:34 +0200, Michał Mirosław wrote: >> > > On Fri, May 27, 2011 at 04:45:50PM +0100, Ben Hutchings wrote: >> > > > On Fri, 2011-05-27 at 17:28 +0200, Michał Mirosław wrote: >> > [...] >> > > > > (note: ETHTOOL_S{SG,...} are not ever going away) >> > > > > - causes NETIF_F_* to be an ABI >> > > > If feature flag numbers are not stable then what is the point of >> > > > /sys/class/net/<name>/features? Also, I'm not aware that features have >> > > > ever been renumbered in the past. >> > > Since no NETIF_F_* were exported earlier, I assume /sys/class/net/*/features >> > > is a debugging aid. What is it used for besides that? >> > xen-api <https://github.com/xen-org/xen-api> uses it in >> > scripts/InterfaceReconfigureVswitch.py. Though it doesn't seem to be >> > used for a particularly good reason... >> >> Look like it should use ETHTOOL_GFLAGS instead for netdev_has_vlan_accel(). ETHTOOL_GFLAGS didn't expose the vlan acceleration flags until 2.6.37, which is why /sys/class/net was used instead. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <BANLkTime8PHYe+BFELt92gg7SZ91xKvAwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [Xen-devel] Re: [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return [not found] ` <BANLkTime8PHYe+BFELt92gg7SZ91xKvAwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2011-05-29 9:38 ` Michał Mirosław [not found] ` <20110529093849.GA5245-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Michał Mirosław @ 2011-05-29 9:38 UTC (permalink / raw) To: Jesse Gross Cc: dev-yBygre7rU0TnMu66kgdUjQ, xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, Ian Campbell, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xen-api-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR, Ben Hutchings, David Miller On Sat, May 28, 2011 at 10:31:03AM -0700, Jesse Gross wrote: > 2011/5/28 Ian Campbell <Ian.Campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>: > > On Sat, 2011-05-28 at 08:35 +0100, Michał Mirosław wrote: > >> On Sat, May 28, 2011 at 12:25:55AM +0100, Ben Hutchings wrote: > >> > On Fri, 2011-05-27 at 18:34 +0200, Michał Mirosław wrote: > >> > > On Fri, May 27, 2011 at 04:45:50PM +0100, Ben Hutchings wrote: > >> > > > On Fri, 2011-05-27 at 17:28 +0200, Michał Mirosław wrote: > >> > [...] > >> > > > > (note: ETHTOOL_S{SG,...} are not ever going away) > >> > > > > - causes NETIF_F_* to be an ABI > >> > > > If feature flag numbers are not stable then what is the point of > >> > > > /sys/class/net/<name>/features? Also, I'm not aware that features have > >> > > > ever been renumbered in the past. > >> > > Since no NETIF_F_* were exported earlier, I assume /sys/class/net/*/features > >> > > is a debugging aid. What is it used for besides that? > >> > xen-api <https://github.com/xen-org/xen-api> uses it in > >> > scripts/InterfaceReconfigureVswitch.py. Though it doesn't seem to be > >> > used for a particularly good reason... > >> Look like it should use ETHTOOL_GFLAGS instead for netdev_has_vlan_accel(). > ETHTOOL_GFLAGS didn't expose the vlan acceleration flags until 2.6.37, > which is why /sys/class/net was used instead. https://github.com/xen-org/xen-api/commit/78b8078e6ae3cf48179859bed6350bb326987546 The commit using it was introduced after 2.6.37 kernel was released and uses undocumented acccess path to the bits in question. What is the kernel patch this commit is referring to? Best Regards, Michał Mirosław ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20110529093849.GA5245-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>]
* Re: [Xen-devel] Re: [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return [not found] ` <20110529093849.GA5245-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> @ 2011-05-31 18:43 ` Jesse Gross 0 siblings, 0 replies; 5+ messages in thread From: Jesse Gross @ 2011-05-31 18:43 UTC (permalink / raw) To: Michał Mirosław Cc: dev-yBygre7rU0TnMu66kgdUjQ, xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, Ian Campbell, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xen-api-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR, Ben Hutchings, David Miller 2011/5/29 Michał Mirosław <mirq-linux@rere.qmqm.pl>: > On Sat, May 28, 2011 at 10:31:03AM -0700, Jesse Gross wrote: >> 2011/5/28 Ian Campbell <Ian.Campbell@citrix.com>: >> > On Sat, 2011-05-28 at 08:35 +0100, Michał Mirosław wrote: >> >> On Sat, May 28, 2011 at 12:25:55AM +0100, Ben Hutchings wrote: >> >> > On Fri, 2011-05-27 at 18:34 +0200, Michał Mirosław wrote: >> >> > > On Fri, May 27, 2011 at 04:45:50PM +0100, Ben Hutchings wrote: >> >> > > > On Fri, 2011-05-27 at 17:28 +0200, Michał Mirosław wrote: >> >> > [...] >> >> > > > > (note: ETHTOOL_S{SG,...} are not ever going away) >> >> > > > > - causes NETIF_F_* to be an ABI >> >> > > > If feature flag numbers are not stable then what is the point of >> >> > > > /sys/class/net/<name>/features? Also, I'm not aware that features have >> >> > > > ever been renumbered in the past. >> >> > > Since no NETIF_F_* were exported earlier, I assume /sys/class/net/*/features >> >> > > is a debugging aid. What is it used for besides that? >> >> > xen-api <https://github.com/xen-org/xen-api> uses it in >> >> > scripts/InterfaceReconfigureVswitch.py. Though it doesn't seem to be >> >> > used for a particularly good reason... >> >> Look like it should use ETHTOOL_GFLAGS instead for netdev_has_vlan_accel(). >> ETHTOOL_GFLAGS didn't expose the vlan acceleration flags until 2.6.37, >> which is why /sys/class/net was used instead. > > https://github.com/xen-org/xen-api/commit/78b8078e6ae3cf48179859bed6350bb326987546 > > The commit using it was introduced after 2.6.37 kernel was released Well people do use kernels other than the most recently released one... > and uses > undocumented acccess path to the bits in question. What is the kernel patch > this commit is referring to? It's a temporary workaround to deal with the fact that many drivers that support vlan acceleration do not properly handle vlan packets if the corresponding group isn't configured on them. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-31 18:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110516.140958.625993829749556424.davem@davemloft.net>
[not found] ` <20110519100331.GA25103@rere.qmqm.pl>
[not found] ` <20110524091437.GA10779@rere.qmqm.pl>
[not found] ` <20110524.153930.610330240390616957.davem@davemloft.net>
[not found] ` <20110524215923.GA20138@rere.qmqm.pl>
[not found] ` <1306505626.2759.4.camel@bwh-desktop>
[not found] ` <20110527152809.GA7620@rere.qmqm.pl>
[not found] ` <1306511150.2759.17.camel@bwh-desktop>
[not found] ` <20110527163409.GA8497@rere.qmqm.pl>
[not found] ` <1306538755.2759.31.camel@bwh-desktop>
2011-05-28 7:35 ` [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return Michał Mirosław
[not found] ` <20110528073525.GA19033-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2011-05-28 10:07 ` [Xen-devel] " Ian Campbell
[not found] ` <1306577228.23577.17.camel-ztPmHsLffjjnO4AKDKe2m+kiAK3p4hvP@public.gmane.org>
2011-05-28 17:31 ` Jesse Gross
[not found] ` <BANLkTime8PHYe+BFELt92gg7SZ91xKvAwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-29 9:38 ` Michał Mirosław
[not found] ` <20110529093849.GA5245-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2011-05-31 18:43 ` Jesse Gross
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).