xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 9/9] xl: new "check-xl-disk-parse" test script for disk parser
Date: Thu, 2 Jun 2011 18:55:46 +0100	[thread overview]
Message-ID: <1307037346-31251-10-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1307037346-31251-9-git-send-email-ian.jackson@eu.citrix.com>

This runs "xl block-attach -N 1 <some strings>" for various sets of
strings and checks that the output is as expected.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 tools/libxl/check-xl-disk-parse |   82 +++++++++++++++++++++++++++++++++++++++
 1 files changed, 82 insertions(+), 0 deletions(-)
 create mode 100755 tools/libxl/check-xl-disk-parse

diff --git a/tools/libxl/check-xl-disk-parse b/tools/libxl/check-xl-disk-parse
new file mode 100755
index 0000000..caaff9d
--- /dev/null
+++ b/tools/libxl/check-xl-disk-parse
@@ -0,0 +1,82 @@
+#!/bin/bash
+
+set -e
+
+fprefix=tmp.check-xl-disk-parse
+
+expected () {
+    cat >$fprefix.expected
+}
+
+failures=0
+
+one () {
+    expected_rc=$1; shift
+    printf "test case %s...\n" "$*"
+    set +e
+    LD_LIBRARY_PATH=.:../libxc:../xenstore \
+        ./xl block-attach -N 1 "$@" </dev/null >$fprefix.actual 2>/dev/null
+    actual_rc=$?
+    diff -u $fprefix.expected $fprefix.actual
+    diff_rc=$?
+    set -e
+    if [ $actual_rc != $expected_rc ] || [ $diff_rc != 0 ]; then
+        echo >&2 "test case \`$*' failed ($actual_rc $diff_rc)"
+        failures=$(( $failures + 1 ))
+    fi
+}
+
+complete () {
+    if [ "$failures" = 0 ]; then
+        echo all ok.; exit 0
+    else
+        echo "$failures tests failed."; exit 1
+    fi
+}
+
+e=255
+
+
+#---------- test data ----------
+#
+# culled from docs/misc/xl-disk-configuration.txt
+
+expected </dev/null
+one $e foo
+
+expected <<END
+disk.backend_domid = 0
+disk.pdev_path =     /dev/vg/guest-volume
+disk.vdev =          hda
+disk.backend =       0
+disk.format =        4
+disk.script =        (null)
+disk.removable =     0
+disk.readwrite =     1
+disk.is_cdrom =      0
+END
+one 0 /dev/vg/guest-volume,,hda
+one 0 /dev/vg/guest-volume,raw,hda,rw
+one 0 "format=raw, vdev=hda, access=rw, target=/dev/vg/guest-volume"
+one 0  format=raw  vdev=hda  access=rw  target=/dev/vg/guest-volume
+one 0 raw:/dev/vg/guest-volume,hda,w
+
+expected <<END
+disk.backend_domid = 0
+disk.pdev_path =     /root/image.iso
+disk.vdev =          hdc
+disk.backend =       0
+disk.format =        4
+disk.script =        (null)
+disk.removable =     1
+disk.readwrite =     0
+disk.is_cdrom =      1
+END
+one 0 /root/image.iso,,hdc,cdrom
+one 0 /root/image.iso,,hdc,,cdrom
+one 0 /root/image.iso,raw,hdc,devtype=cdrom
+one 0 "format=raw, vdev=hdc, access=ro, devtype=cdrom, target=/root/image.iso"
+one 0  format=raw  vdev=hdc  access=ro  devtype=cdrom  target=/root/image.iso
+one 0 raw:/root/image.iso,hdc:cdrom,ro
+
+complete
-- 
1.5.6.5

  reply	other threads:[~2011-06-02 17:55 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 17:55 [PATCH 0/9] libxl: disk configuration handling Ian Jackson
2011-06-02 17:55 ` [PATCH 1/9] libxl: disks: Make LIBXL_DISK_BACKEND_UNKNOWN work Ian Jackson
2011-06-02 17:55   ` [PATCH 2/9] libxl: disks: new xlu_disk_parse function Ian Jackson
2011-06-02 17:55     ` [PATCH 3/9] libxl: disks: commit libxlu_disk_l.[ch] flex output Ian Jackson
2011-06-02 17:55       ` [PATCH 4/9] docs: update xl-disk-configuration.txt to describe new syntax Ian Jackson
2011-06-02 17:55         ` [PATCH 5/9] xl: disks: replace config file disk spec parser with call to xlu_disk_parse Ian Jackson
2011-06-02 17:55           ` [PATCH 6/9] xl: disks: replace block-attach disk config parser with call to xlu_parse_disk Ian Jackson
2011-06-02 17:55             ` [PATCH 7/9] libxl: disks: allow specification of "backendtype=phy|tap|qdisk" Ian Jackson
2011-06-02 17:55               ` [PATCH 8/9] xl: xl block-attach -N (dry run) option Ian Jackson
2011-06-02 17:55                 ` Ian Jackson [this message]
2011-06-03 10:38                   ` [PATCH 9/9] xl: new "check-xl-disk-parse" test script for disk parser Ian Campbell
2011-06-03 11:12                     ` Ian Jackson
2011-06-03 14:25                     ` Ian Jackson
2011-06-03 14:32                       ` Ian Campbell
2011-06-03 10:30                 ` [PATCH 8/9] xl: xl block-attach -N (dry run) option Ian Campbell
2011-06-03 11:17                   ` Ian Jackson
2011-06-03 14:54                   ` [PATCHES 00/08-11] xl dry run option, and disk parser test script Ian Jackson
2011-06-03 14:54                     ` [PATCH 08/11] xl: new global -N option for dry run Ian Jackson
2011-06-03 14:54                       ` [PATCH 09/11] xl: implement -N (dry run) global option for create and cpupool-create Ian Jackson
2011-06-03 14:54                         ` [PATCH 10/11] xl: xl block-attach -N (dry run) option Ian Jackson
2011-06-03 14:54                           ` [PATCH 11/11] xl: new "check-xl-disk-parse" test script for disk parser Ian Jackson
2011-06-03 15:09                             ` Ian Campbell
2011-06-03 15:05                           ` [PATCH 10/11] xl: xl block-attach -N (dry run) option Ian Campbell
2011-06-23 16:36                           ` Ian Campbell
2011-06-03 15:04                         ` [PATCH 09/11] xl: implement -N (dry run) global option for create and cpupool-create Ian Campbell
2011-06-03 15:04                       ` [PATCH 08/11] xl: new global -N option for dry run Ian Campbell
2011-06-03 10:38                 ` [PATCH 8/9] xl: xl block-attach -N (dry run) option Ian Campbell
2011-06-03 11:13                   ` Ian Jackson
2011-06-03 12:09                     ` Ian Campbell
2011-06-03 10:46                 ` Ian Campbell
2011-06-03 11:16                   ` Ian Jackson
2011-06-03 13:00                     ` Ian Campbell
2011-06-03 10:27               ` [PATCH 7/9] libxl: disks: allow specification of "backendtype=phy|tap|qdisk" Ian Campbell
2011-06-03 14:24                 ` Ian Jackson
2011-06-03 14:32                   ` Ian Campbell
2011-06-03 10:21             ` [PATCH 6/9] xl: disks: replace block-attach disk config parser with call to xlu_parse_disk Ian Campbell
2011-06-03 10:20           ` [PATCH 5/9] xl: disks: replace config file disk spec parser with call to xlu_disk_parse Ian Campbell
2011-06-03 10:19         ` [PATCH 4/9] docs: update xl-disk-configuration.txt to describe new syntax Ian Campbell
2011-06-03 10:19       ` [PATCH 3/9] libxl: disks: commit libxlu_disk_l.[ch] flex output Ian Campbell
2011-06-03 10:08     ` [PATCH 2/9] libxl: disks: new xlu_disk_parse function Ian Campbell
2011-06-03 11:10       ` Ian Jackson
2011-06-03 12:03         ` Ian Campbell
2011-06-03 14:06           ` Ian Campbell
2011-06-21 17:27             ` Ian Jackson
2011-06-22  8:19               ` Ian Campbell
2011-06-22 13:16                 ` Ian Campbell
2011-06-03 10:18     ` Ian Campbell
2011-06-03  8:42   ` [PATCH 1/9] libxl: disks: Make LIBXL_DISK_BACKEND_UNKNOWN work Ian Campbell
2011-06-03 14:24     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307037346-31251-10-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).