From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 10/11] xl: xl block-attach -N (dry run) option
Date: Fri, 3 Jun 2011 15:54:26 +0100 [thread overview]
Message-ID: <1307112867-15977-4-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1307112867-15977-3-git-send-email-ian.jackson@eu.citrix.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
tools/libxl/xl_cmdimpl.c | 16 ++++++++++++++++
tools/libxl/xl_cmdtable.c | 2 +-
2 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 5c63686..d22610c 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -4042,6 +4042,22 @@ int main_blockattach(int argc, char **argv)
disk.backend_domid = be_domid;
+ if (dryrun_only) {
+ /* fixme: this should be generated from the idl */
+ /* fixme: enums (backend, format) should be converted to strings */
+ printf("disk.backend_domid = %"PRIx32"\n", disk.backend_domid);
+ printf("disk.pdev_path = %s\n", disk.pdev_path);
+ printf("disk.vdev = %s\n", disk.vdev);
+ printf("disk.backend = %d\n", disk.backend);
+ printf("disk.format = %d\n", disk.format);
+ printf("disk.script = %s\n", disk.script);
+ printf("disk.removable = %d\n", disk.removable);
+ printf("disk.readwrite = %d\n", disk.readwrite);
+ printf("disk.is_cdrom = %d\n", disk.is_cdrom);
+ if (ferror(stdout) || fflush(stdout)) { perror("stdout"); exit(-1); }
+ return 0;
+ }
+
if (libxl_device_disk_add(ctx, fe_domid, &disk)) {
fprintf(stderr, "libxl_device_disk_add failed.\n");
}
diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c
index 924920b..e6ff877 100644
--- a/tools/libxl/xl_cmdtable.c
+++ b/tools/libxl/xl_cmdtable.c
@@ -256,7 +256,7 @@ struct cmd_spec cmd_table[] = {
"<Domain> <DevId|mac>",
},
{ "block-attach",
- &main_blockattach, 0,
+ &main_blockattach, 1,
"Create a new virtual block device",
"<Domain> <disk-spec-component(s)>...",
},
--
1.5.6.5
next prev parent reply other threads:[~2011-06-03 14:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 17:55 [PATCH 0/9] libxl: disk configuration handling Ian Jackson
2011-06-02 17:55 ` [PATCH 1/9] libxl: disks: Make LIBXL_DISK_BACKEND_UNKNOWN work Ian Jackson
2011-06-02 17:55 ` [PATCH 2/9] libxl: disks: new xlu_disk_parse function Ian Jackson
2011-06-02 17:55 ` [PATCH 3/9] libxl: disks: commit libxlu_disk_l.[ch] flex output Ian Jackson
2011-06-02 17:55 ` [PATCH 4/9] docs: update xl-disk-configuration.txt to describe new syntax Ian Jackson
2011-06-02 17:55 ` [PATCH 5/9] xl: disks: replace config file disk spec parser with call to xlu_disk_parse Ian Jackson
2011-06-02 17:55 ` [PATCH 6/9] xl: disks: replace block-attach disk config parser with call to xlu_parse_disk Ian Jackson
2011-06-02 17:55 ` [PATCH 7/9] libxl: disks: allow specification of "backendtype=phy|tap|qdisk" Ian Jackson
2011-06-02 17:55 ` [PATCH 8/9] xl: xl block-attach -N (dry run) option Ian Jackson
2011-06-02 17:55 ` [PATCH 9/9] xl: new "check-xl-disk-parse" test script for disk parser Ian Jackson
2011-06-03 10:38 ` Ian Campbell
2011-06-03 11:12 ` Ian Jackson
2011-06-03 14:25 ` Ian Jackson
2011-06-03 14:32 ` Ian Campbell
2011-06-03 10:30 ` [PATCH 8/9] xl: xl block-attach -N (dry run) option Ian Campbell
2011-06-03 11:17 ` Ian Jackson
2011-06-03 14:54 ` [PATCHES 00/08-11] xl dry run option, and disk parser test script Ian Jackson
2011-06-03 14:54 ` [PATCH 08/11] xl: new global -N option for dry run Ian Jackson
2011-06-03 14:54 ` [PATCH 09/11] xl: implement -N (dry run) global option for create and cpupool-create Ian Jackson
2011-06-03 14:54 ` Ian Jackson [this message]
2011-06-03 14:54 ` [PATCH 11/11] xl: new "check-xl-disk-parse" test script for disk parser Ian Jackson
2011-06-03 15:09 ` Ian Campbell
2011-06-03 15:05 ` [PATCH 10/11] xl: xl block-attach -N (dry run) option Ian Campbell
2011-06-23 16:36 ` Ian Campbell
2011-06-03 15:04 ` [PATCH 09/11] xl: implement -N (dry run) global option for create and cpupool-create Ian Campbell
2011-06-03 15:04 ` [PATCH 08/11] xl: new global -N option for dry run Ian Campbell
2011-06-03 10:38 ` [PATCH 8/9] xl: xl block-attach -N (dry run) option Ian Campbell
2011-06-03 11:13 ` Ian Jackson
2011-06-03 12:09 ` Ian Campbell
2011-06-03 10:46 ` Ian Campbell
2011-06-03 11:16 ` Ian Jackson
2011-06-03 13:00 ` Ian Campbell
2011-06-03 10:27 ` [PATCH 7/9] libxl: disks: allow specification of "backendtype=phy|tap|qdisk" Ian Campbell
2011-06-03 14:24 ` Ian Jackson
2011-06-03 14:32 ` Ian Campbell
2011-06-03 10:21 ` [PATCH 6/9] xl: disks: replace block-attach disk config parser with call to xlu_parse_disk Ian Campbell
2011-06-03 10:20 ` [PATCH 5/9] xl: disks: replace config file disk spec parser with call to xlu_disk_parse Ian Campbell
2011-06-03 10:19 ` [PATCH 4/9] docs: update xl-disk-configuration.txt to describe new syntax Ian Campbell
2011-06-03 10:19 ` [PATCH 3/9] libxl: disks: commit libxlu_disk_l.[ch] flex output Ian Campbell
2011-06-03 10:08 ` [PATCH 2/9] libxl: disks: new xlu_disk_parse function Ian Campbell
2011-06-03 11:10 ` Ian Jackson
2011-06-03 12:03 ` Ian Campbell
2011-06-03 14:06 ` Ian Campbell
2011-06-21 17:27 ` Ian Jackson
2011-06-22 8:19 ` Ian Campbell
2011-06-22 13:16 ` Ian Campbell
2011-06-03 10:18 ` Ian Campbell
2011-06-03 8:42 ` [PATCH 1/9] libxl: disks: Make LIBXL_DISK_BACKEND_UNKNOWN work Ian Campbell
2011-06-03 14:24 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307112867-15977-4-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).