xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <liuw@liuw.name>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [PATCH] qemu-xen: fix unmapping logic in hw/xen_console.c
Date: Wed, 08 Jun 2011 17:44:08 +0800	[thread overview]
Message-ID: <1307526248.31359.28.camel@limbo> (raw)

This is a patch for qemu-xen. Don't know if it is the right place to
post.

It has been fixed in upstream QEMU.

------8<----------------
commit 28ec10ef3ff22873cd3f1b703d3aecbc93cbf680
Author: Wei Liu <liuw@liuw.name>
Date:   Wed Jun 8 17:40:02 2011 +0800

    qemu-xen: fix unmapping logic in hw/xen_console.c.
    
    Signed-off-by: Wei Liu <liuw@liuw.name>

diff --git a/hw/xen_console.c b/hw/xen_console.c
index 0a2374c..d7099c4 100644
--- a/hw/xen_console.c
+++ b/hw/xen_console.c
@@ -258,7 +258,7 @@ static void con_disconnect(struct XenDevice *xendev)
     xen_be_unbind_evtchn(&con->xendev);
 
     if (con->sring) {
-        if (!xendev->dev)
+        if (!xendev->gnttabdev)
 	    munmap(con->sring, XC_PAGE_SIZE);
         else
             xc_gnttab_munmap(xendev->gnttabdev, con->sring, 1);

             reply	other threads:[~2011-06-08  9:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08  9:44 Wei Liu [this message]
2011-06-08 10:54 ` [PATCH] qemu-xen: fix unmapping logic in hw/xen_console.c Stefano Stabellini
2011-06-08 11:33   ` Wei Liu
2011-06-08 11:53     ` Stefano Stabellini
2011-06-21 16:59       ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307526248.31359.28.camel@limbo \
    --to=liuw@liuw.name \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).