From: Wei Liu <liuw@liuw.name>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH] libxl: initialize domid to 0 in libxl__create_stubdom
Date: Thu, 09 Jun 2011 13:03:43 +0800 [thread overview]
Message-ID: <1307595829.8990.9.camel@limbo> (raw)
The uninitialized domid may cause libxl__domain_make to fail.
In libxl__domain_make:
assert(!libxl_domid_valid_guest(*domid)).
Signed-off-by: Wei Liu <liuw@liuw.name>
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 47a51c8..fbee1d0 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -570,7 +570,7 @@ static int libxl__create_stubdom(libxl__gc *gc,
libxl_domain_create_info c_info;
libxl_domain_build_info b_info;
libxl__domain_build_state state;
- uint32_t domid;
+ uint32_t domid = 0;
char **args;
struct xs_permissions perm[2];
xs_transaction_t t;
next reply other threads:[~2011-06-09 5:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 5:03 Wei Liu [this message]
2011-06-09 7:55 ` [PATCH] libxl: initialize domid to 0 in libxl__create_stubdom Ian Campbell
2011-06-09 8:31 ` Wei Liu
2011-06-09 10:23 ` Ian Campbell
2011-06-09 11:03 ` Wei Liu
2011-06-09 11:35 ` Ian Campbell
2011-06-09 14:41 ` Stefano Stabellini
2011-06-09 14:43 ` Ian Campbell
2011-06-17 17:46 ` Ian Jackson
2011-06-20 19:06 ` Stefano Stabellini
2011-06-21 3:29 ` ZhouPeng
2011-06-21 7:31 ` ZhouPeng
2011-06-21 12:28 ` Ian Jackson
2011-06-21 13:31 ` ZhouPeng
2011-06-21 12:25 ` Ian Jackson
2011-06-21 14:05 ` Stefano Stabellini
2011-06-21 14:25 ` Ian Jackson
2011-06-22 17:59 ` Stefano Stabellini
2011-06-24 14:37 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307595829.8990.9.camel@limbo \
--to=liuw@liuw.name \
--cc=Ian.Campbell@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).