From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] libxl: initialize domid to 0 in libxl__create_stubdom Date: Thu, 09 Jun 2011 16:31:27 +0800 Message-ID: <1307608287.31235.17.camel@limbo> References: <1307595829.8990.9.camel@limbo> <1307606121.775.761.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1307606121.775.761.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thu, 2011-06-09 at 08:55 +0100, Ian Campbell wrote: > On Thu, 2011-06-09 at 06:03 +0100, Wei Liu wrote: > > The uninitialized domid may cause libxl__domain_make to fail. > > > > In libxl__domain_make: > > assert(!libxl_domid_valid_guest(*domid)). > > > > Signed-off-by: Wei Liu > > That check seems pretty odd to me at first but the commit message of > 22842:ccfa0527893e does a good job of explaining why so: > > Acked-by: Ian Campbell > > although it's not clear why libxl__domain_make doesn't just set an > invalid value as it's first act and save the callers the effort, the net > result would still be the correct semantics for libxl_domid_valid_guest > when the function exits. > I think the commit message of 22842:ccfa0527893e says pretty clear that it is caller's responsibility to initialize domid to a invalid value. However, libxl__make_domain sets domid=-1 a few lines after the check. This confuses me. > Ian. >