From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
"Tim (Xen.org)" <tim@xen.org>,
George Dunlap <George.Dunlap@citrix.com>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH v9 5/7] memory: add check_get_page_from_gfn() as a wrapper...
Date: Wed, 19 Sep 2018 09:24:00 +0000 [thread overview]
Message-ID: <1312622e083d470ca94ec2902435db9f@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5BA2156E02000078001E9CF9@prv1-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 19 September 2018 10:23
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Julien Grall <julien.grall@arm.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; George Dunlap <George.Dunlap@citrix.com>; Ian
> Jackson <Ian.Jackson@citrix.com>; Wei Liu <wei.liu2@citrix.com>; Stefano
> Stabellini <sstabellini@kernel.org>; xen-devel <xen-
> devel@lists.xenproject.org>; Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com>; Tim (Xen.org) <tim@xen.org>
> Subject: RE: [Xen-devel] [PATCH v9 5/7] memory: add
> check_get_page_from_gfn() as a wrapper...
>
> >>> On 19.09.18 at 10:54, <Paul.Durrant@citrix.com> wrote:
> >> -----Original Message-----
> >> From: Jan Beulich [mailto:JBeulich@suse.com]
> >> Sent: 19 September 2018 09:34
> >> To: Paul Durrant <Paul.Durrant@citrix.com>
> >> Cc: Julien Grall <julien.grall@arm.com>; Andrew Cooper
> >> <Andrew.Cooper3@citrix.com>; George Dunlap <George.Dunlap@citrix.com>;
> Ian
> >> Jackson <Ian.Jackson@citrix.com>; Wei Liu <wei.liu2@citrix.com>;
> Stefano
> >> Stabellini <sstabellini@kernel.org>; xen-devel <xen-
> >> devel@lists.xenproject.org>; Konrad Rzeszutek Wilk
> >> <konrad.wilk@oracle.com>; Tim (Xen.org) <tim@xen.org>
> >> Subject: RE: [Xen-devel] [PATCH v9 5/7] memory: add
> >> check_get_page_from_gfn() as a wrapper...
> >>
> >> >>> On 19.09.18 at 09:56, <Paul.Durrant@citrix.com> wrote:
> >> >> From: Jan Beulich [mailto:JBeulich@suse.com]
> >> >> Sent: 19 September 2018 07:03
> >> >>
> >> >> >>> On 18.09.18 at 18:37, <Paul.Durrant@citrix.com> wrote:
> >> >> > Moving to p2m-common won't work. The function declaration involves
> a
> >> >> > p2m_type_t argument and that enum is defined in the arm and x86
> >> specific
> >> >> > headers. I propose therefore to leave this patch as-is.
> >> >>
> >> >> Leaving the duplication in place is just the last resort imo. Does
> >> >> xen/mm.h
> >> >> not work either?
> >> >
> >> > No, it won't. It has to be something *after* the definition of the
> >> > p2m_type_t enum. I could, as Julien suggested, move the inclusion of
> >> > p2m-common after that point, but it would mean the header guards
> would
> >> cease
> >> > to DTRT of course. I'm not sure whether C will allow me to forward
> >> declare
> >> > the enum (not something I've tried) but I could give that a go. Any
> >> other
> >> > suggestions?
> >>
> >> I'm afraid I don't understand your concern wrt include guards. Each
> header
> >> has its own. I'm actually surprised the current inclusion point is at
> the
> >> top
> >> of the file, rather than after at least the basic type definitions each
> >> arch
> >> has to supply.
> >>
> >
> > Ok, if we include p2m-common in the middle of p2m, and then add stuff
> > dependent on the declaration of p2m_type_t, what happens when a source
> module
> > explicitly includes p2m-common prior to p2m?
>
> This is not supposed to happen, as this header is supposed to only be
> included from the per-arch p2m.h; we should put an #error there. I
> see there's exactly one violation of this (drivers/vpci/header.c). But
> your series can go in as is; I'll try to remember to clean this up.
>
Ok, thanks.
Paul
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-19 9:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 15:21 [PATCH v9 0/6] paravirtual IOMMU pre-requisites and clean-up Paul Durrant
2018-09-13 15:21 ` [PATCH v9 1/7] iommu: introduce the concept of DFN Paul Durrant
2018-09-14 2:27 ` Tian, Kevin
2018-09-13 15:21 ` [PATCH v9 2/7] iommu: make use of type-safe DFN and MFN in exported functions Paul Durrant
2018-09-13 15:21 ` [PATCH v9 3/7] iommu: push use of type-safe DFN and MFN into iommu_ops Paul Durrant
2018-09-13 15:21 ` [PATCH v9 4/7] iommu: don't domain_crash() inside iommu_map/unmap_page() Paul Durrant
2018-09-13 15:21 ` [PATCH v9 5/7] memory: add check_get_page_from_gfn() as a wrapper Paul Durrant
2018-09-18 13:16 ` Jan Beulich
2018-09-18 14:03 ` Paul Durrant
2018-09-18 14:51 ` Jan Beulich
2018-09-18 16:37 ` Paul Durrant
2018-09-19 6:03 ` Jan Beulich
2018-09-19 7:56 ` Paul Durrant
2018-09-19 8:01 ` Paul Durrant
2018-09-19 8:31 ` Jan Beulich
2018-09-19 8:59 ` Roger Pau Monné
2018-09-19 16:13 ` Wei Liu
2018-09-19 8:34 ` Jan Beulich
2018-09-19 8:54 ` Paul Durrant
2018-09-19 9:22 ` Jan Beulich
2018-09-19 9:24 ` Paul Durrant [this message]
2018-09-19 9:29 ` Roger Pau Monné
[not found] ` <304E51960200007575B6CDDB@prv1-mh.provo.novell.com>
2018-09-19 9:34 ` Jan Beulich
2018-09-13 15:21 ` [PATCH v7 6/6] vtd: add lookup_page method to iommu_ops Paul Durrant
2018-09-13 15:22 ` Paul Durrant
2018-09-13 15:21 ` [PATCH v9 6/7] vtd: add missing check for shared EPT Paul Durrant
2018-09-14 2:29 ` Tian, Kevin
2018-09-13 15:21 ` [PATCH v9 7/7] vtd: add lookup_page method to iommu_ops Paul Durrant
2018-09-14 2:30 ` Tian, Kevin
2018-09-18 13:20 ` Jan Beulich
2018-09-18 14:00 ` Paul Durrant
2018-09-18 14:50 ` Jan Beulich
2018-09-18 16:03 ` Paul Durrant
2018-09-13 15:24 ` [PATCH v9 0/6] paravirtual IOMMU pre-requisites and clean-up Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312622e083d470ca94ec2902435db9f@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).