From: <stefano.stabellini@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: xen: __hvm_pci_intx_assert should check for gsis remapped onto pirqs
Date: Wed, 31 Aug 2011 11:24:05 +0100 [thread overview]
Message-ID: <1314786246-15149-2-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <1314786246-15149-1-git-send-email-stefano.stabellini@eu.citrix.com>
If the isa irq corresponding to a particular gsi is disabled while the
gsi is enabled, __hvm_pci_intx_assert will always inject the gsi through
the violapic, even if the gsi has been remapped onto a pirq.
This patch makes sure that even in this case we inject the notification
appropriately.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
diff -r 5814da0753df xen/arch/x86/hvm/irq.c
--- a/xen/arch/x86/hvm/irq.c Tue Aug 30 11:56:22 2011 +0000
+++ b/xen/arch/x86/hvm/irq.c Tue Aug 30 11:56:37 2011 +0000
@@ -29,7 +29,7 @@
#include <asm/msi.h>
/* Must be called with hvm_domain->irq_lock hold */
-static void assert_irq(struct domain *d, unsigned ioapic_gsi, unsigned pic_irq)
+static void assert_gsi(struct domain *d, unsigned ioapic_gsi)
{
struct pirq *pirq =
pirq_info(d, domain_emuirq_to_pirq(d, ioapic_gsi));
@@ -40,6 +40,11 @@ static void assert_irq(struct domain *d,
return;
}
vioapic_irq_positive_edge(d, ioapic_gsi);
+}
+
+static void assert_irq(struct domain *d, unsigned ioapic_gsi, unsigned pic_irq)
+{
+ assert_gsi(d, ioapic_gsi);
vpic_irq_positive_edge(d, pic_irq);
}
@@ -66,7 +71,7 @@ static void __hvm_pci_intx_assert(
gsi = hvm_pci_intx_gsi(device, intx);
if ( hvm_irq->gsi_assert_count[gsi]++ == 0 )
- vioapic_irq_positive_edge(d, gsi);
+ assert_gsi(d, gsi);
link = hvm_pci_intx_link(device, intx);
isa_irq = hvm_irq->pci_link.route[link];
next prev parent reply other threads:[~2011-08-31 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 10:24 xen: fix hvm_domain_use_pirq's behavior stefano.stabellini
2011-08-31 10:24 ` stefano.stabellini [this message]
2011-08-31 10:27 ` xen: __hvm_pci_intx_assert should check for gsis remapped onto pirqs Stefano Stabellini
2011-08-31 10:24 ` xen: get_free_pirq: make sure that the returned pirq is allocated stefano.stabellini
2011-08-31 10:26 ` xen: fix hvm_domain_use_pirq's behavior Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314786246-15149-2-git-send-email-stefano.stabellini@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).