From: annie.li@oracle.com
To: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
konrad.wilk@oracle.com, jeremy@goop.org
Cc: kurt.hackel@oracle.com, paul.durrant@citrix.com,
Ian.Campbell@citrix.com, annie.li@oracle.com
Subject: [PATCH 2/4] xen/granttable: Refactor some code
Date: Tue, 22 Nov 2011 09:58:47 +0800 [thread overview]
Message-ID: <1321927127-3958-1-git-send-email-annie.li@oracle.com> (raw)
In-Reply-To: <4ECA416D.90602@oracle.com>
From: Annie Li <annie.li@oracle.com>
Signed-off-by: Annie Li <annie.li@oracle.com>
---
drivers/xen/grant-table.c | 15 ++++++++++-----
1 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
index 18355a5..0518d04 100644
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -257,15 +257,17 @@ EXPORT_SYMBOL_GPL(gnttab_query_foreign_access);
static int gnttab_end_foreign_access_ref_v1(grant_ref_t ref, int readonly)
{
u16 flags, nflags;
+ u16 *pflags;
- nflags = gnttab_shared.v1[ref].flags;
+ pflags = &gnttab_shared.v1[ref].flags;
+ nflags = *pflags;
do {
flags = nflags;
if (flags & (GTF_reading|GTF_writing)) {
printk(KERN_ALERT "WARNING: g.e. still in use!\n");
return 0;
}
- } while ((nflags = sync_cmpxchg(&gnttab_shared.v1[ref].flags, flags, 0)) != flags);
+ } while ((nflags = sync_cmpxchg(pflags, flags, 0)) != flags);
return 1;
}
@@ -316,20 +318,23 @@ static unsigned long gnttab_end_foreign_transfer_ref_v1(grant_ref_t ref)
{
unsigned long frame;
u16 flags;
+ u16 *pflags;
+
+ pflags = &gnttab_shared.v1[ref].flags;
/*
* If a transfer is not even yet started, try to reclaim the grant
* reference and return failure (== 0).
*/
- while (!((flags = gnttab_shared.v1[ref].flags) & GTF_transfer_committed)) {
- if (sync_cmpxchg(&gnttab_shared.v1[ref].flags, flags, 0) == flags)
+ while (!((flags = *pflags) & GTF_transfer_committed)) {
+ if (sync_cmpxchg(pflags, flags, 0) == flags)
return 0;
cpu_relax();
}
/* If a transfer is in progress then wait until it is completed. */
while (!(flags & GTF_transfer_completed)) {
- flags = gnttab_shared.v1[ref].flags;
+ flags = *pflags;
cpu_relax();
}
--
1.7.6.4
next prev parent reply other threads:[~2011-11-22 1:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 12:17 Third version patches for upstreaming grant table version 2 annie li
2011-11-22 1:58 ` [PATCH 1/4] xen/granttable: Introducing grant table V2 stucture annie.li
2011-11-22 1:58 ` annie.li [this message]
2011-11-22 1:59 ` [PATCH 3/4] xen/granttable: Grant tables V2 implementation annie.li
2011-11-22 9:29 ` Ian Campbell
2011-11-22 10:02 ` ANNIE LI
2011-11-22 14:31 ` Konrad Rzeszutek Wilk
2011-11-22 1:59 ` [PATCH 4/4] xen/granttable: Keep code format clean annie.li
-- strict thread matches above, loose matches on Subject: below --
2011-11-22 10:21 Forth version patches for upstreaming grant table version 2 ANNIE LI
2011-11-22 10:26 ` [PATCH 2/4] xen/granttable: Refactor some code annie.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321927127-3958-1-git-send-email-annie.li@oracle.com \
--to=annie.li@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).