xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 06/10] DROP: libxl: rename libxl__free_all
Date: Fri, 6 Jan 2012 20:35:03 +0000	[thread overview]
Message-ID: <1325882107-5794-7-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1325882107-5794-1-git-send-email-ian.jackson@eu.citrix.com>

*** THIS PATCH WILL PROBABLY BE DROPPED as it is no longer needed
    in the current version of later patches. ***

libxl__free_all is going to gain some extra functionality, which will
mean that the name is no longer accurate.  Rename it to
libxl__gc_cleanup.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
 tools/libxl/libxl.h          |    2 +-
 tools/libxl/libxl_internal.c |    2 +-
 tools/libxl/libxl_internal.h |    4 ++--
 tools/libxl/libxl_qmp.c      |    2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
index 723eac2..9ae7cea 100644
--- a/tools/libxl/libxl.h
+++ b/tools/libxl/libxl.h
@@ -119,7 +119,7 @@
  *
  * No temporary objects allocated from the pool may be explicitly freed.
  * Therefore public functions which initialize a libxl__gc MUST call
- * libxl__free_all() before returning.
+ * libxl__gc_cleanup() before returning.
  */
 #ifndef LIBXL_H
 #define LIBXL_H
diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c
index 49b0dab..cc98d86 100644
--- a/tools/libxl/libxl_internal.c
+++ b/tools/libxl/libxl_internal.c
@@ -53,7 +53,7 @@ int libxl__ptr_add(libxl__gc *gc, void *ptr)
     return 0;
 }
 
-void libxl__free_all(libxl__gc *gc)
+void libxl__gc_cleanup(libxl__gc *gc)
 {
     void *ptr;
     int i;
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 1dadf15..df1dfde 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -190,7 +190,7 @@ static inline libxl_ctx *libxl__gc_owner(libxl__gc *gc)
 /* register @ptr in @gc for free on exit from outermost libxl callframe. */
 _hidden int libxl__ptr_add(libxl__gc *gc, void *ptr);
 /* if this is the outermost libxl callframe then free all pointers in @gc */
-_hidden void libxl__free_all(libxl__gc *gc);
+_hidden void libxl__gc_cleanup(libxl__gc *gc);
 /* allocate and zero @bytes. (similar to a gc'd malloc(3)+memzero()) */
 _hidden void *libxl__zalloc(libxl__gc *gc, int bytes);
 /* allocate and zero memory for an array of @nmemb members of @size each.
@@ -744,7 +744,7 @@ libxl__device_model_version_running(libxl__gc *gc, uint32_t domid);
  */
 
 #define GC_INIT(ctx)  libxl__gc gc[1]; LIBXL_INIT_GC(gc[0],ctx)
-#define GC_FREE       libxl__free_all(gc)
+#define GC_FREE       libxl__gc_cleanup(gc)
 #define CTX           libxl__gc_owner(gc)
 
 
diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
index 61d9769..58f5283 100644
--- a/tools/libxl/libxl_qmp.c
+++ b/tools/libxl/libxl_qmp.c
@@ -528,7 +528,7 @@ static int qmp_send(libxl__qmp_handler *qmp,
 
     rc = qmp->last_id_used;
 out:
-    libxl__free_all(&gc);
+    libxl__gc_cleanup(&gc);
     return rc;
 }
 
-- 
1.7.2.5

  parent reply	other threads:[~2012-01-06 20:35 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 20:34 [PATCH v6 00/10] libxl: event API Ian Jackson
2012-01-06 20:34 ` [PATCH 01/10] libxl: make LIBXL_INIT_GC a statement, not an initialiser Ian Jackson
2012-01-06 20:34 ` [PATCH 02/10] xenstore: New function xs_path_is_subpath Ian Jackson
2012-01-13 10:39   ` Ian Campbell
2012-01-06 20:35 ` [PATCH 03/10] libxl: move a lot more includes into libxl_internal.h Ian Jackson
2012-01-13 10:41   ` Ian Campbell
2012-01-13 13:37     ` Ian Jackson
2012-01-13 13:39       ` Ian Campbell
2012-01-13 16:23         ` Ian Jackson
2012-01-06 20:35 ` [PATCH 04/10] libxl: Provide more formal libxl__ctx_lock and _unlock Ian Jackson
2012-01-13 10:42   ` Ian Campbell
2012-01-06 20:35 ` [PATCH 05/10] libxl: Fix leaks on context init failure Ian Jackson
2012-01-13 10:43   ` Ian Campbell
2012-01-13 15:58     ` Ian Jackson
2012-01-06 20:35 ` Ian Jackson [this message]
2012-01-06 20:35 ` [PATCH 07/10] libxl: New API for providing OS events to libxl Ian Jackson
2012-01-11 17:32   ` Stefano Stabellini
2012-01-12 11:28     ` Ian Campbell
2012-01-12 13:49       ` Stefano Stabellini
2012-01-12 15:49       ` Ian Jackson
2012-01-12 15:56     ` Ian Jackson
2012-01-13 15:07   ` Ian Campbell
2012-01-13 15:47     ` Ian Jackson
2012-01-13 15:56       ` Ian Campbell
2012-01-13 16:34         ` Ian Jackson
2012-01-06 20:35 ` [PATCH 08/10] libxl: New event generation API Ian Jackson
2012-01-13 15:22   ` Ian Campbell
2012-01-13 15:49     ` Ian Jackson
2012-01-06 20:35 ` [PATCH 09/10] libxl: introduce libxl_fd_set_nonblock, rationalise _cloexec Ian Jackson
2012-01-13 10:45   ` Ian Campbell
2012-01-13 15:54     ` Ian Jackson
2012-01-06 20:35 ` [PATCH 10/10] libxl: Permit multithreaded event waiting Ian Jackson
2012-01-09 17:34 ` [PATCH RFC v6.1 11-14/10] libxl: asynchronous operations Ian Jackson
2012-01-09 17:34 ` [PATCH 11/10] libxl: Asynchronous/long-running operation infrastructure Ian Jackson
2012-01-09 17:34 ` [PATCH 12/10] libxl: New convenience macro CONTAINING_STRUCT Ian Jackson
2012-01-13 10:49   ` Ian Campbell
2012-01-13 13:53     ` Ian Jackson
2012-01-13 15:06       ` Ian Campbell
2012-01-09 17:34 ` [PATCH 13/10] libxl: Introduce libxl__ev_devstate Ian Jackson
2012-01-09 17:34 ` [PATCH 14/10] libxl: Convert to asynchronous: device removal Ian Jackson
2012-01-13 14:50 ` [PATCH v6 00/10] libxl: event API Ian Campbell
2012-01-13 15:03   ` Ian Jackson
2012-01-13 17:43     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325882107-5794-7-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).