Re: [PATCH v4 13/25] arm: domain_build

[Ian Campbell <Ian.Campbell@citrix.com>]

On Mon, 2012-01-09 at 18:29 +0000, David Vrabel wrote:
> On 09/01/12 17:59, stefano.stabellini@eu.citrix.com wrote:
> > 
> > +int construct_dom0(struct domain *d)
> > +{
> [...]
> > +    printk("Routing peripheral interrupts to guest\n");
> > +    /* TODO Get from device tree */
> 
> Can you route interrupt 34 (timer0) to dom0 as well?  Current mainline
> kernels are using this timer.
> 
> David
> 
> From 88148e85b2d8d9bf60564d4b5eb2ac73d8389fa5 Mon Sep 17 00:00:00 2001
> From: David Vrabel <david.vrabel@citrix.com>
> Date: Mon, 9 Jan 2012 15:21:37 +0000
> Subject: [PATCH] ARM: route timer0 interrupt to dom0

This is the peripheral timer rather than one of the generic timers
provided by the processor. Exposing it to dom0 is correct.

> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

> ---
>  xen/arch/arm/domain_build.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index c36b888..cbbc0b9 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -108,6 +108,7 @@ int construct_dom0(struct domain *d)
> 
>      printk("Routing peripheral interrupts to guest\n");
>      /* TODO Get from device tree */
> +    gic_route_irq_to_guest(d, 34, "timer0");
>      /*gic_route_irq_to_guest(d, 37, "uart0"); -- XXX used by Xen*/
>      gic_route_irq_to_guest(d, 38, "uart1");
>      gic_route_irq_to_guest(d, 39, "uart2");