From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 14 of 14 V3] libxl: Introduce a new guest
 config file parameter
Date: Wed, 11 Jan 2012 08:43:44 +0000
Message-ID: <1326271424.29084.93.camel@dagon.hellion.org.uk>
References: <patchbomb.1326215226@gran.amd.com>
	<39eb093ea89eeaa4dbff.1326215240@gran.amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <39eb093ea89eeaa4dbff.1326215240@gran.amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Wei Wang <wei.wang2@amd.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, "JBeulich@suse.com" <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2012-01-10 at 17:07 +0000, Wei Wang wrote:
> # HG changeset patch
> # User Wei Wang <wei.wang2@amd.com>
> # Date 1326213623 -3600
> # Node ID 39eb093ea89eeaa4dbff29439499f2a289291ff0
> # Parent  9e89b6485b6c91a8d563c46c47a8d768eee7d1f2
> libxl: Introduce a new guest config file parameter
> Use iommu = {1,0} to enable or disable guest iommu emulation.
> Default value is 0.

Please patch docs/man/xl.cfg.pod.5 to explain this new option to the
users, when/why they would enable it etc.

A description of the hardware requirements might be useful, although
perhaps not in that document. Likewise the guest OS requirements. Is
there a passthru page on the wiki which could be amended?

> Signed-off-by: Wei Wang <wei.wang2@amd.com>
[...]
> diff -r 9e89b6485b6c -r 39eb093ea89e tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c	Tue Jan 10 17:40:20 2012 +0100
> +++ b/tools/libxl/xl_cmdimpl.c	Tue Jan 10 17:40:23 2012 +0100
> @@ -360,6 +360,7 @@ static void printf_info(int domid,
>          printf("\t\t\t(vpt_align %d)\n", b_info->u.hvm.vpt_align);
>          printf("\t\t\t(timer_mode %d)\n", b_info->u.hvm.timer_mode);
>          printf("\t\t\t(nestedhvm %d)\n", b_info->u.hvm.nested_hvm);
> +        printf("\t\t\t(iommu %d)\n", b_info->u.hvm.iommu);

I wonder if we should stop adding new stuff to this output, it's for
legacy users anyway.

Ian.