From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 2 of 3] libxl: allow for specifying the CPU affinity in the config file. Date: Fri, 13 Jan 2012 09:13:34 +0000 Message-ID: <1326446014.2397.2.camel@Abyss.citrite.net> References: <1326304198.2401.6.camel@Abyss> <1326304831.12973.3.camel@Abyss> <1326357782.17210.213.camel@zakaz.uk.xensource.com> <1326408997.4494.11.camel@Abyss> <1326442153.29084.110.camel@dagon.hellion.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1518013184561947225==" Return-path: In-Reply-To: <1326442153.29084.110.camel@dagon.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: xen-devel , Ian Jackson List-Id: xen-devel@lists.xenproject.org --===============1518013184561947225== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-qMsmrjnoslYQ35ReUtyH" --=-qMsmrjnoslYQ35ReUtyH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2012-01-13 at 08:09 +0000, Ian Campbell wrote:=20 > > Having this set to "none" here simplifies a bit the code when we came t= o > > config file parsing (if I set it to "any CPU" here, I'll have to reset > > to "none" before parsing). Also, default is exactly what you're > > suggesting already, as I set the map to "any CPU" if no "cpus" config > > option is found. >=20 > xl's default is "any CPU" but libxl's default is "no CPU" which will > mean every toolstack author needs to do be aware of this even if they > don't care about affinity. >=20 Ok, I think I see your point now, which I didn't in the first place, and neither yesterday while replying. Sorry, my fault, I agree I need to set it to "any CPU" right here. > > Anyway, I guess I can do as you suggest if you really think it's > > better. :-) >=20 > Please ;-) >=20 Sure, will do like that. > > It is different, and that was intentional. What I wanted, was the synta= x > > to be exactly the same of `xl vcpu-pin', which is the command line > > equivalent of this option, much more than cpupool-*. If you want, I > > think I can easily enable list-like CPU specification as in cpupool > > config file so that _both_ syntax are allowed. What do you think? >=20 > I think supporting both makes sense, we do something similar in a couple > of places already. >=20 Ok then. Thanks, Dario --=20 <> (Raistlin Majere) ------------------------------------------------------------------- Dario Faggioli, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) PhD Candidate, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa (Italy) --=-qMsmrjnoslYQ35ReUtyH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk8P9b4ACgkQk4XaBE3IOsQw3wCgmylrVFHK1nncJAgZFZkrQqux MVAAnR803uG3hKPRXUE6ejbU8WIs8VFr =whDY -----END PGP SIGNATURE----- --=-qMsmrjnoslYQ35ReUtyH-- --===============1518013184561947225== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1518013184561947225==--