From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCHv2 2 of 2] Move IOMMU faults handling into softirq for AMD-Vi. Date: Wed, 18 Jan 2012 09:53:20 +0100 Message-ID: <1326876800.2375.18.camel@Abyss> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0938465777819928307==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Wei Wang2 , "allen.m.kay@intel.com" , xen-devel@lists.xensource.com, Tim Deegan , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============0938465777819928307== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-j2CJJSqMR/ySgF/V7Jqc" --=-j2CJJSqMR/ySgF/V7Jqc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2012-01-17 at 11:17 +0000, Keir Fraser wrote:=20 > > Dealing with interrupts from AMD-Vi IOMMU(s) is deferred to a softirq-t= asklet, > > raised by the actual IRQ handler. To avoid more interrupts being genera= ted > > (because of further faults), they must be masked in the IOMMU within th= e low > > level IRQ handler and enabled back in the tasklet body. Notice that thi= s may > > cause the log to overflow, but none of the existing entry will be overw= ritten. > >=20 > > Signed-off-by: Dario Faggioli >=20 > This patch needs fixing to apply to xen-unstable tip. Please do that and > resubmit. >=20 I see. I can easily rebase the patch but there are functional changes involved, so I'd like to know what you think it's best to do first. In particular, the clash is against Wei's patches introducing PPR. So now the IOMMU interrupt handler checks both event log and ppr log. Question is, should I move _BOTH_ these checks into softirq or just defer event log processing, and leave ppr log handling in hard-irq context? Quickly looking at the new specs, it seems to me that deferring both should be fine, but I'd really appreciate your thoughts... Wei, Jan, Tim? Thanks and regards, Dario --=20 <> (Raistlin Majere) ------------------------------------------------------------------- Dario Faggioli, http://retis.sssup.it/people/faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) PhD Candidate, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa (Italy) --=-j2CJJSqMR/ySgF/V7Jqc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk8WiIAACgkQk4XaBE3IOsSgRACfTrKRFsf0Z7rOT3Nsrg85swe/ 0LQAn2fixhNOxDh5qg3ATE+KBKuJTFSu =OTnY -----END PGP SIGNATURE----- --=-j2CJJSqMR/ySgF/V7Jqc-- --===============0938465777819928307== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0938465777819928307==--