From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 3/3] xenoprof: Make the escape code consistent across 32 and 64-bit xen Date: Mon, 23 Jan 2012 16:51:43 +0000 Message-ID: <1327337503.26455.314.camel@elijah> References: <4F19B633.6090105@citrix.com> <4F1D3D1D020000780006E514@nat28.tlf.novell.com> <1327313777.24561.9.camel@zakaz.uk.xensource.com> <4F1D48BA020000780006E55F@nat28.tlf.novell.com> <4F1D7702020000780006E6C2@nat28.tlf.novell.com> <1327334483.26455.260.camel@elijah> <4F1D991A020000780006E74E@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F1D991A020000780006E74E@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: George Dunlap , Marcus Granado , xen-devel , "Keir (Xen.org)" , Ian Campbell List-Id: xen-devel@lists.xenproject.org On Mon, 2012-01-23 at 16:30 +0000, Jan Beulich wrote: > > The attached patch fixes the build (with the original patch un-reverted > > of course), by making the internal calls explicitly take 64-bit values > > for eip, rather than "unsigned long". Will that suffice? > > Looks correct and sufficient, but with the original patch already > reverted folding the changes here into the original and re-submitting > would probably the best route to go. I really prefer to keep patches with no functional change separate from those with a pretty major functional change; even if the major functional change is only one line. :-) -George