xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, avi@redhat.com,
	anthony@codemonkey.ws,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled
Date: Fri, 27 Jan 2012 12:26:54 +0000	[thread overview]
Message-ID: <1327667215-5411-4-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1201271211400.3196@kaball-desktop>

Also delta in qemu_next_alarm_deadline is a 64 bit value so set the
default to INT64_MAX instead of INT32_MAX.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 qemu-timer.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/qemu-timer.c b/qemu-timer.c
index cd026c6..648db1d 100644
--- a/qemu-timer.c
+++ b/qemu-timer.c
@@ -106,23 +106,21 @@ static inline int alarm_has_dynticks(struct qemu_alarm_timer *t)
 
 static int64_t qemu_next_alarm_deadline(void)
 {
-    int64_t delta;
+    int64_t delta = INT64_MAX;
     int64_t rtdelta;
 
-    if (!use_icount && vm_clock->active_timers) {
+    if (!use_icount && vm_clock->enabled && vm_clock->active_timers) {
         delta = vm_clock->active_timers->expire_time -
                      qemu_get_clock_ns(vm_clock);
-    } else {
-        delta = INT32_MAX;
     }
-    if (host_clock->active_timers) {
+    if (host_clock->enabled && host_clock->active_timers) {
         int64_t hdelta = host_clock->active_timers->expire_time -
                  qemu_get_clock_ns(host_clock);
         if (hdelta < delta) {
             delta = hdelta;
         }
     }
-    if (rt_clock->active_timers) {
+    if (rt_clock->enabled && rt_clock->active_timers) {
         rtdelta = (rt_clock->active_timers->expire_time -
                  qemu_get_clock_ns(rt_clock));
         if (rtdelta < delta) {
-- 
1.7.2.5

  parent reply	other threads:[~2012-01-27 12:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27 12:26 [PATCH v2 0/5] prevent Qemu from waking up needlessly Stefano Stabellini
2012-01-27 12:26 ` [PATCH v2 1/5] xen: do not initialize the interval timer emulator Stefano Stabellini
2012-01-27 12:26 ` [PATCH v2 2/5] xen: disable rtc_clock Stefano Stabellini
2012-01-27 14:41   ` Paolo Bonzini
2012-01-30 11:56     ` Stefano Stabellini
2012-01-30 11:59       ` Paolo Bonzini
2012-01-30 18:53         ` Stefano Stabellini
2012-01-30 19:28         ` Anthony Liguori
2012-01-31  7:30           ` Paolo Bonzini
2012-01-27 12:26 ` [PATCH v2 3/5] xen: introduce an event channel for buffered io event notifications Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini [this message]
2012-01-27 14:42   ` [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled Paolo Bonzini
2012-01-27 15:43     ` Stefano Stabellini
2012-01-27 15:53       ` Stefano Stabellini
2012-01-27 12:26 ` [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h Stefano Stabellini
2012-01-27 14:43   ` Paolo Bonzini
2012-01-27 15:44     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327667215-5411-4-git-send-email-stefano.stabellini@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).