From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] libxl: fix bootloader args setting
Date: Sat, 4 Feb 2012 09:57:40 +0100
Message-ID: <1328345860.3610.6.camel@cthulhu.hellion.org.uk>
References: <9ae3b2b7b494ab8fbc54.1328294398@zhigang.us.oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <9ae3b2b7b494ab8fbc54.1328294398@zhigang.us.oracle.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Zhigang Wang <zhigang.x.wang@oracle.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2012-02-03 at 13:39 -0500, Zhigang Wang wrote:
> # HG changeset patch
> # User Zhigang Wang <zhigang.x.wang@oracle.com>
> # Date 1328294351 18000
> # Node ID 9ae3b2b7b494ab8fbc54aa923101dc48132c6c6e
> # Parent  e2722b24dc0962de37215320b05d1bb7c4c42864
> libxl: fix bootloader args setting

This looks correct but please could you expand your commit message to
explain what the actual issue you are fixing is e.g. such that someone
reading through the logs in the future can tell that this is a fix they
might want for the issue they are seeing

Ian.

> 
> Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>
> 
> diff -r e2722b24dc09 -r 9ae3b2b7b494 tools/libxl/libxl_bootloader.c
> --- a/tools/libxl/libxl_bootloader.c	Thu Jan 26 17:43:31 2012 +0000
> +++ b/tools/libxl/libxl_bootloader.c	Fri Feb 03 13:39:11 2012 -0500
> @@ -49,9 +49,11 @@ static char **make_bootloader_args(libxl
>      flexarray_set(args, nr++, libxl__sprintf(gc, "--output-directory=%s", "/var/run/libxl/"));
>  
>      if (info->u.pv.bootloader_args) {
> -        char *p = info->u.pv.bootloader_args[0];
> -        while (*(p++))
> -            flexarray_set(args, nr++, p);
> +        char **p = info->u.pv.bootloader_args;
> +        while (*p) {
> +            flexarray_set(args, nr++, *p);
> +            p++;
> +        }
>      }
>  
>      flexarray_set(args, nr++, disk);
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel