From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr. Date: Mon, 13 Feb 2012 12:20:13 +0000 Message-ID: <1329135613-26061-12-git-send-email-anthony.perard@citrix.com> References: <1329135613-26061-1-git-send-email-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1329135613-26061-1-git-send-email-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: QEMU-devel Cc: Anthony PERARD , Anthony Liguori , Xen Devel , "Michael S . Tsirkin" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Actually, pci_parse_devaddr checks if the dom/bus of the PCI address exist. But this should be the jobs of a caller. In fact, the two callers of this function will try to retrieve the PCIBus related to the devaddr and return an error if they cannot. Signed-off-by: Anthony PERARD --- hw/pci.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index ebb5de9..da7cf79 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -529,10 +529,6 @@ int pci_parse_devaddr(const char *addr, int *domp, int *busp, if (*e) return -1; - /* Note: QEMU doesn't implement domains other than 0 */ - if (!pci_find_bus(pci_find_root_bus(dom), bus)) - return -1; - *domp = dom; *busp = bus; *slotp = slot; -- Anthony PERARD