xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Tim Deegan <tim@xen.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH] arm: fixup hard tabs
Date: Mon, 13 Feb 2012 19:52:46 +0000	[thread overview]
Message-ID: <1329162766.8906.13.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20120213193930.GA96441@ocelot.phlegethon.org>

On Mon, 2012-02-13 at 19:39 +0000, Tim Deegan wrote:
> At 19:09 +0000 on 13 Feb (1329160194), Ian Campbell wrote:
> > (note that the mangling resulted in _7_ space indentation, which is
> > worse than just about anything)
> > 
> > > No other file in the tree has tabs why should these?
> > > 
> > > Nak, unless your intention is to immediately apply a patch converting
> > > tabs to 8 spaces.
> 
> We really ought to take this - the current state is both accidental and
> nonsensical.

Yes, that is my primary concern right now.

> That said, for head.S, which is the only place I've introduced tabs, I'm
> happy to have the whole file converted to (8) spaces if you also fix the
> emacs runes at the foot of the file to DTRT.

Similarly for entry.S which I think I just styled after head.S.

> For asm code taken from linux, have we already mangled them enough
> that applying upstream fixes would be hard?

I don't think so, once this fix is applied they will be back to being
pretty close.

Ian.

      reply	other threads:[~2012-02-13 19:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 18:03 [PATCH] arm: fixup hard tabs Ian Campbell
2012-02-13 18:26 ` David Vrabel
2012-02-13 19:09   ` Ian Campbell
2012-02-13 19:39     ` Tim Deegan
2012-02-13 19:52       ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329162766.8906.13.camel@dagon.hellion.org.uk \
    --to=ian.campbell@citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).