xl_cmdimpl.c errors

xl_cmdimpl.c errors

[jacek burghardt]

[-- Attachment #1.1: Type: text/plain, Size: 1012 bytes --]

I am trying to create arch linux package xen 4.2 unstable . It builds mots
of xen fine but I get error with xl_cmdimpl.c
4.2/src/xen-unstable.git-build/tools/libxl/../../tools/include  -c -o
xl_cmdimpl.o xl_cmdimpl.c
xl_cmdimpl.c: In function 'printf_info':
xl_cmdimpl.c:300:5: error: statement with no effect [-Werror=unused-value]
xl_cmdimpl.c:300:21: error: expected ';' before 'conf'
xl_cmdimpl.c:306:28: error: 'conf' undeclared (first use in this function)
xl_cmdimpl.c:306:28: note: each undeclared identifier is reported only once
for each function it appears in
xl_cmdimpl.c:306:5: error: too many arguments to function 'yajl_gen_alloc'
/usr/include/yajl/yajl_gen.h:118:23: note: declared here
xl_cmdimpl.c:339:5: error: passing argument 3 of 'yajl_gen_get_buf' from
incompatible pointer type [-Werror]
/usr/include/yajl/yajl_gen.h:144:30: note: expected 'size_t *' but argument
is of type 'unsigned int *'
cc1: all warnings being treated as errors
I saw this error mentioned I wonder if there is patch

[-- Attachment #1.2: Type: text/html, Size: 1140 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: xl_cmdimpl.c errors

[Ian Campbell]

On Fri, 2012-02-17 at 05:36 +0000, jacek burghardt wrote:
> I am trying to create arch linux package xen 4.2 unstable . It builds
> mots of xen fine but I get error with xl_cmdimpl.c
> 4.2/src/xen-unstable.git-build/tools/libxl/../../tools/include  -c -o
> xl_cmdimpl.o xl_cmdimpl.c
> xl_cmdimpl.c: In function 'printf_info':
> xl_cmdimpl.c:300:5: error: statement with no effect
> [-Werror=unused-value]
> xl_cmdimpl.c:300:21: error: expected ';' before 'conf'
> xl_cmdimpl.c:306:28: error: 'conf' undeclared (first use in this
> function)
> xl_cmdimpl.c:306:28: note: each undeclared identifier is reported only
> once for each function it appears in
> xl_cmdimpl.c:306:5: error: too many arguments to function
> 'yajl_gen_alloc'
> /usr/include/yajl/yajl_gen.h:118:23: note: declared here
> xl_cmdimpl.c:339:5: error: passing argument 3 of 'yajl_gen_get_buf'
> from incompatible pointer type [-Werror]
> /usr/include/yajl/yajl_gen.h:144:30: note: expected 'size_t *' but
> argument is of type 'unsigned int *'
> cc1: all warnings being treated as errors
> I saw this error mentioned I wonder if there is patch 

This is due to xl only supporting yajl1 while you seem to have yajl2.

Olaf Herring posted a patch last week (or maybe the week before). I
thought it had been committed but perhaps not -- although you don't say
which xen-unstable you are running so I don't know how up to date you
are -- this is always worth mentioning.

Ian.

Re: xl_cmdimpl.c errors

[Fantu]

Yes on unstable there is yajl 2 support:
http://xenbits.xen.org/hg/xen-unstable.hg/rev/ab397bd22b56
Probably today I compile unstable on Wheezy with yajl2 and I will report if
complete and correct

--
View this message in context: http://xen.1045712.n5.nabble.com/xl-cmdimpl-c-errors-tp5491537p5491845.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: xl_cmdimpl.c errors

[Fantu]

I have tested now xen-unstable rev. 24823:b75664e53905 build on Wheezy and is
failed with same error:
...
gcc  -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable   -D__XEN_TOOLS__ -MMD -MF .xl_cmdimpl.o.d 
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls
-Werror -Wno-format-zero-length -Wmissing-declarations
-Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC
-DHAVE_YAJL_VERSION
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/libxc
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/include 
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/libxl
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/libxc
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/include
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/include  -c -o
xl_cmdimpl.o xl_cmdimpl.c 
xl_cmdimpl.c: In function âprintf_infoâ:
xl_cmdimpl.c:300:5: error: statement with no effect [-Werror=unused-value]
xl_cmdimpl.c:300:21: error: expected â;â before âconfâ
xl_cmdimpl.c:306:28: error: âconfâ undeclared (first use in this function)
xl_cmdimpl.c:306:28: note: each undeclared identifier is reported only once
for each function it appears in
xl_cmdimpl.c:306:5: error: too many arguments to function âyajl_gen_allocâ
/usr/include/yajl/yajl_gen.h:118:23: note: declared here
xl_cmdimpl.c:339:5: error: passing argument 3 of âyajl_gen_get_bufâ from
incompatible pointer type [-Werror]
/usr/include/yajl/yajl_gen.h:144:30: note: expected âsize_t *â but argument
is of type âunsigned int *â
cc1: all warnings being treated as errors

make[3]: *** [xl_cmdimpl.o] Error 1
make[3]: Leaving directory `/mnt/vm/xen/xen-unstable.hg/tools/libxl'
make[2]: *** [subdir-install-libxl] Error 2
make[2]: Leaving directory `/mnt/vm/xen/xen-unstable.hg/tools'
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory `/mnt/vm/xen/xen-unstable.hg/tools'
make: *** [install-tools] Error 2

If can help I attach also full build log: 
http://xen.1045712.n5.nabble.com/file/n5492170/xenbuild.log xenbuild.log 

I tried to solve fast the problem for continue with also spice build but I
not been able to fix this problem.

Thanks for any reply and sorry for bad english.

--
View this message in context: http://xen.1045712.n5.nabble.com/xl-cmdimpl-c-errors-tp5491537p5492170.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: xl_cmdimpl.c errors

[Ian Campbell]

On Fri, 2012-02-17 at 11:06 +0000, Fantu wrote:
> I have tested now xen-unstable rev. 24823:b75664e53905 build on Wheezy and is
> failed with same error:

It seems that Olaf's fix to xl (<patchbomb.1328791978@probook.site>)
isn't in the tree yet, only Roger's fix to libxl is. I presume it is in
IanJ's queue and will committed in the fullness of time.

Ian.

Re: xl_cmdimpl.c errors

[Fantu]

The patch to fix is the second here, right?
http://xen.1045712.n5.nabble.com/PATCH-0-of-2-rename-libxl-yajl-gen-alloc-td5469362.html

Now I try to apply it and rebuild, after I report it if it works.



--
View this message in context: http://xen.1045712.n5.nabble.com/xl-cmdimpl-c-errors-tp5491537p5492321.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: xl_cmdimpl.c errors

[Fantu]

With only second patch fail:

gcc  -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable   -D__XEN_TOOLS__ -MMD -MF .xl_cmdimpl.o.d 
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls
-Werror -Wno-format-zero-length -Wmissing-declarations
-Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC
-DHAVE_YAJL_VERSION
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/libxc
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/include 
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/libxl
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/libxc
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/include
-I/mnt/vm/xen/xen-unstable.hg/tools/libxl/../../tools/include  -c -o
xl_cmdimpl.o xl_cmdimpl.c 
xl_cmdimpl.c: In function âprintf_infoâ:
xl_cmdimpl.c:305:5: error: implicit declaration of function
âlibxl_yajl_gen_allocâ [-Werror=implicit-function-declaration]
xl_cmdimpl.c:305:10: error: assignment makes pointer from integer without a
cast [-Werror]
cc1: all warnings being treated as errors

make[3]: *** [xl_cmdimpl.o] Error 1
make[3]: Leaving directory `/mnt/vm/xen/xen-unstable.hg/tools/libxl'
make[2]: *** [subdir-install-libxl] Error 2
make[2]: Leaving directory `/mnt/vm/xen/xen-unstable.hg/tools'
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory `/mnt/vm/xen/xen-unstable.hg/tools'
make: *** [install-tools] Error 2

Probably need also the first, not add after read this:
> tools/libxl: rename libxl__yajl_gen_alloc
>
> libxl__yajl_gen_alloc() is called by generic code,
> rename it to libx__yajl_gen_alloc().

Other than this typo both patches in this series look good to me,
thanks.

Acked-by: Ian Campbell <[hidden email]> 

Now I try also first.

--
View this message in context: http://xen.1045712.n5.nabble.com/xl-cmdimpl-c-errors-tp5491537p5492438.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: xl_cmdimpl.c errors

[Ian Campbell]

On Fri, 2012-02-17 at 13:14 +0000, Fantu wrote:
> With only second patch fail:

Right, you need both patches since the second relies on the renaming
done in the first..

Re: xl_cmdimpl.c errors

[Fantu]

With the 2 patches build done without error, now I also start testing xen
unstable on Wheezy.

--
View this message in context: http://xen.1045712.n5.nabble.com/xl-cmdimpl-c-errors-tp5491537p5492514.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: xl_cmdimpl.c errors

[jacek burghardt]

[-- Attachment #1.1: Type: text/plain, Size: 767 bytes --]

I get this error
/home/dev/xen/xen-4.2/src/xen-unstable.git-build/tools/libxl/xl_cmdimpl.c:305:
undefined reference to `libx_yajl_gen_alloc'

/home/dev/xen/xen-4.2/src/xen-unstable.git-build/tools/libxl/xl_cmdimpl.c:305:
undefined reference to `libxl_yajl_gen_alloc

On Fri, Feb 17, 2012 at 6:36 AM, Fantu <fantonifabio@tiscali.it> wrote:

> With the 2 patches build done without error, now I also start testing xen
> unstable on Wheezy.
>
> --
> View this message in context:
> http://xen.1045712.n5.nabble.com/xl-cmdimpl-c-errors-tp5491537p5492514.html
> Sent from the Xen - Dev mailing list archive at Nabble.com.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>

[-- Attachment #1.2: Type: text/html, Size: 1351 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: xl_cmdimpl.c errors

[Fantu]

On Wheezy (Debian 7) after the 2 patches and change about /usr/lib is
working.

@jacek burghardt: 
where you are installing Xen?
yajl2 is installed?
The patches are applied correctly, the second need change for lines not
matching.

--
View this message in context: http://xen.1045712.n5.nabble.com/xl-cmdimpl-c-errors-tp5491537p5502259.html
Sent from the Xen - Dev mailing list archive at Nabble.com.