From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 11 of 23] libxl: make libxl_device_console internal
Date: Tue, 21 Feb 2012 10:23:18 +0000 [thread overview]
Message-ID: <1329819798.25232.80.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20290.40164.889190.529383@mariner.uk.xensource.com>
On Mon, 2012-02-20 at 19:20 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH 11 of 23] libxl: make libxl_device_console internal"):
> > libxl: make libxl_device_console internal
> >
> > consoles are not directly exposed to users of the library and there are no API
> > functions for manipluating them (only the console_exec function). Rather than
> > commit to a particular API now make the type internal.
>
> Isn't it likely that at some future point we will re-expose this
> difference, for example by providing a different set of access
> functions ?
Very likely. However I didn't want to design or commit to an API in the
total absence of users.
When a user does come along it is much easier to add a completely new
API rather than to fix an existing broken one. It's easier to do this in
a manner which users of the library can cope with in a compatible way
e.g. adding a new API is easier to check for with ./configure.
> The fact that all you can do with a console is exec the xenconsole
> client is pretty crazy.
Yup.
Ian.
next prev parent reply other threads:[~2012-02-21 10:23 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 16:52 [PATCH 00 of 23] libxl: improved handling for default values in API Ian Campbell
2012-02-13 16:52 ` [PATCH 01 of 23] libxl: Document _init/_dispose/_setdefault functions Ian Campbell
2012-02-20 19:08 ` Ian Jackson
2012-02-21 10:18 ` Ian Campbell
2012-02-13 16:52 ` [PATCH 02 of 23] libxl: provide _init and _setdefault for libxl_domain_create_info Ian Campbell
2012-02-20 19:09 ` Ian Jackson
2012-02-13 16:52 ` [PATCH 03 of 23] libxl: provide _init and _setdefault for libxl_domain_build_info Ian Campbell
2012-02-13 16:52 ` [PATCH 04 of 23] libxl: use an explicit LIBXL_TIMER_MODE_DEFAULT value Ian Campbell
2012-02-20 19:16 ` Ian Jackson
2012-02-13 16:52 ` [PATCH 05 of 23] libxl: drop 8M slack for PV guests Ian Campbell
2012-02-20 19:15 ` Ian Jackson
2012-02-21 10:10 ` Stefano Stabellini
2012-02-21 10:10 ` Ian Campbell
2012-02-21 10:53 ` David Vrabel
2012-02-21 10:59 ` Ian Campbell
2012-02-21 15:27 ` Dan Magenheimer
2012-02-13 16:52 ` [PATCH 06 of 23] libxl: allow specification of testidl random seed Ian Campbell
2012-02-20 19:18 ` Ian Jackson
2012-02-13 16:52 ` [PATCH 07 of 23] libxl: introduce a descriminating default value for memkb fields Ian Campbell
2012-02-20 19:24 ` Ian Jackson
2012-02-13 16:52 ` [PATCH 08 of 23] libxl: disk: use _init/_setdefault Ian Campbell
2012-02-13 16:52 ` [PATCH 09 of 23] libxl: nic: " Ian Campbell
2012-02-13 16:52 ` [PATCH 10 of 23] libxl: vfb/vkb: " Ian Campbell
2012-02-13 16:52 ` [PATCH 11 of 23] libxl: make libxl_device_console internal Ian Campbell
2012-02-20 19:20 ` Ian Jackson
2012-02-21 10:23 ` Ian Campbell [this message]
2012-02-21 12:31 ` Ian Jackson
2012-02-13 16:52 ` [PATCH 12 of 23] libxl: pci: use _init/_setdefault Ian Campbell
2012-02-13 16:52 ` [PATCH 13 of 23] libxl: add new "defbool" built in type Ian Campbell
2012-02-20 19:14 ` Ian Jackson
2012-02-21 10:24 ` Ian Campbell
2012-02-13 16:53 ` [PATCH 14 of 23] libxl: make boolean members of libxl_domain_create_info into libxl_defbool Ian Campbell
2012-02-20 19:18 ` Ian Jackson
2012-02-13 16:53 ` [PATCH 15 " Ian Campbell
2012-02-20 19:25 ` Ian Jackson
2012-02-21 10:58 ` Ian Campbell
2012-02-13 16:53 ` [PATCH 16 of 23] libxl: switch generation id control to libxl_defbool Ian Campbell
2012-02-20 19:16 ` Ian Jackson
2012-02-21 11:01 ` Ian Campbell
2012-02-13 16:53 ` [PATCH 17 of 23] libxl: use defbool for graphics related options Ian Campbell
2012-02-20 19:22 ` Ian Jackson
2012-02-13 16:53 ` [PATCH 18 of 23] libxl: do not explicitly initialise members of build info to zero Ian Campbell
2012-02-20 19:20 ` Ian Jackson
2012-02-13 16:53 ` [PATCH 19 of 23] libxl: switch device model selection over to libxl_defbool Ian Campbell
2012-02-13 16:53 ` [PATCH 20 of 23] libxl: add libxl_domain_build_info_init_type Ian Campbell
2012-02-20 19:22 ` Ian Jackson
2012-02-20 19:24 ` Ian Jackson
2012-02-13 16:53 ` [PATCH 21 of 23] libxl: Make IDL KeyedUnion keyvar an idl.Field Ian Campbell
2012-02-20 19:17 ` Ian Jackson
2012-02-13 16:53 ` [PATCH 22 of 23] libxl: idl: generate KeyedUnion key member as part of the KeyedUnion Ian Campbell
2012-02-13 17:08 ` Ian Jackson
2012-02-13 17:13 ` Ian Campbell
2012-02-13 16:53 ` [PATCH 23 of 23] libxl: autogenerate libxl_FOO_init and libxl_FOO_init_FIELD Ian Campbell
2012-02-20 19:24 ` Ian Jackson
2012-02-21 10:11 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329819798.25232.80.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).