xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Tim.Deegan@citrix.com,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Ian.Campbell@citrix.com, david.vrabel@citrix.com
Subject: [PATCH v3 02/11] arm: fix inflight_irqs list priority ordering
Date: Fri, 2 Mar 2012 14:27:28 +0000	[thread overview]
Message-ID: <1330698457-8622-2-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203021415060.923@kaball-desktop>

Lower priority integers mean higher priority.
Also when we are about to insert the lowest priority IRQ so far, add it
at the end.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 xen/arch/arm/vgic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index dd99629..4d2a0e0 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -567,14 +567,14 @@ void vgic_vcpu_inject_irq(struct vcpu *v, unsigned int irq, int virtual)
     spin_lock(&v->arch.vgic.lock);
     list_for_each_entry ( iter, &v->arch.vgic.inflight_irqs, inflight )
     {
-        if ( iter->priority < priority )
+        if ( iter->priority > priority )
         {
             list_add_tail(&n->inflight, &iter->inflight);
             spin_unlock(&v->arch.vgic.lock);
             return;
         }
     }
-    list_add(&n->inflight, &v->arch.vgic.inflight_irqs);
+    list_add_tail(&n->inflight, &v->arch.vgic.inflight_irqs);
     spin_unlock(&v->arch.vgic.lock);
     /* we have a new higher priority irq, inject it into the guest */
     cpu_raise_softirq(v->processor, VGIC_SOFTIRQ);
-- 
1.7.2.5

  parent reply	other threads:[~2012-03-02 14:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 14:27 [PATCH v3 0/11] xen/arm: event channels and shared_info page Stefano Stabellini
2012-03-02 14:27 ` [PATCH v3 01/11] arm: rename link to inflight Stefano Stabellini
2012-03-14  9:48   ` Ian Campbell
2012-03-02 14:27 ` Stefano Stabellini [this message]
2012-03-14  9:48   ` [PATCH v3 02/11] arm: fix inflight_irqs list priority ordering Ian Campbell
2012-03-02 14:27 ` [PATCH v3 03/11] arm: support fewer LR registers than virtual irqs Stefano Stabellini
2012-03-13 14:30   ` Ian Campbell
2012-03-13 17:31     ` Stefano Stabellini
2012-03-13 17:24       ` Ian Campbell
2012-03-14  9:26   ` Ian Campbell
2012-05-25 13:38     ` Stefano Stabellini
2012-03-02 14:27 ` [PATCH v3 04/11] arm: replace list_del and INIT_LIST_HEAD with list_del_init Stefano Stabellini
2012-03-14  9:49   ` Ian Campbell
2012-03-02 14:27 ` [PATCH v3 05/11] arm: shared_info page allocation and mapping Stefano Stabellini
2012-03-13 17:06   ` Ian Campbell
2012-05-25 13:44     ` Stefano Stabellini
2012-03-14  9:38   ` Ian Campbell
2012-05-25 13:54     ` Stefano Stabellini
2012-05-25 13:58       ` Ian Campbell
2012-03-02 14:27 ` [PATCH v3 06/11] arm: handle dom0_max_vcpus=0 case properly Stefano Stabellini
2012-03-14  9:49   ` Ian Campbell
2012-03-02 14:27 ` [PATCH v3 07/11] arm: use r12 to pass the hypercall number Stefano Stabellini
2012-03-13 15:28   ` Ian Campbell
2012-03-13 16:09     ` Ian Campbell
2012-03-13 16:17       ` WARNING: Xen ARMv7 with Virtualization Extensions Guest ABI has changed Ian Campbell
2012-03-02 14:27 ` [PATCH v3 08/11] arm: introduce more hypercalls Stefano Stabellini
2012-03-14  9:49   ` Ian Campbell
2012-03-02 14:27 ` [PATCH v3 09/11] arm: implement flush_tlb_all_local and flush_tlb_local Stefano Stabellini
2012-03-14  9:49   ` Ian Campbell
2012-03-02 14:27 ` [PATCH v3 10/11] arm: remove VGIC_SOFTIRQ Stefano Stabellini
2012-03-02 14:27 ` [PATCH v3 11/11] arm: implement event injection Stefano Stabellini
2012-03-14  9:50 ` [PATCH v3 0/11] xen/arm: event channels and shared_info page Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330698457-8622-2-git-send-email-stefano.stabellini@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Tim.Deegan@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).