From: Ian Campbell <Ian.Campbell@citrix.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 3/5] RTC: Add UIP(update in progress) check logic
Date: Mon, 5 Mar 2012 10:36:20 -0800 [thread overview]
Message-ID: <1330972580.22559.33.camel@cthulhu.hellion.org.uk> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E087191@SHSMSX101.ccr.corp.intel.com>
On Mon, 2012-03-05 at 03:25 -0500, Zhang, Yang Z wrote:
> The UIP(update in progress) is set when RTC is in updating. And the
> update cycle begins 244us later after UIP is set.
Not arguing against this patch but OOI how important is it to emulate
this behaviour to this level of accuracy? On real hardware the UIP tells
you that the data may not be valid/consistent but I don't think the
emulated RTC has that property (does it?). Do guest OSes rely on seeing
the UIP bit occasionally or have you seen a specific issue which caused
you to make this change?
Ian.
next prev parent reply other threads:[~2012-03-05 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 8:25 [PATCH 3/5] RTC: Add UIP(update in progress) check logic Zhang, Yang Z
2012-03-05 18:36 ` Ian Campbell [this message]
2012-03-06 0:26 ` Zhang, Yang Z
2012-03-06 8:45 ` Jan Beulich
2012-03-06 15:06 ` Ian Campbell
2012-03-05 20:37 ` Tim Deegan
2012-03-06 0:07 ` Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330972580.22559.33.camel@cthulhu.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xensource.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).