Re: Libxl regression on pv domU start

[Ian Campbell <Ian.Campbell@citrix.com>]

On Tue, 2012-03-06 at 09:00 -0500, Fantu wrote:
> Dom0 is Wheezy 64 bit with xen-unstable from source.
> With changeset 24858:a88ba599add1 work, after update to 24967:33659563f589
> not.
> 
> xl create /etc/xen/lucid.cfg
> Parsing config file /etc/xen/lucid.cfg
> xl: libxl.c:214: libxl_defbool_val: Assertion
> `!libxl_defbool_is_default(db)' failed.
> Annullato

The following fixes this for me.

8<----------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1331043402 0
# Node ID 7cedb78a4a1d7b410a787da6401044485a82e1b3
# Parent  e8efe0a654517d9695c391b55b07612ebe79b409
libxl: always set a default value for VFB.opengl

Fixes an assertion reported by Fantu.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r e8efe0a65451 -r 7cedb78a4a1d tools/libxl/libxl.c
--- a/tools/libxl/libxl.c	Fri Mar 02 21:06:14 2012 +0000
+++ b/tools/libxl/libxl.c	Tue Mar 06 14:16:42 2012 +0000
@@ -2255,9 +2255,7 @@ int libxl__device_vfb_setdefault(libxl__
     }
 
     libxl_defbool_setdefault(&vfb->sdl.enable, false);
-    if (libxl_defbool_val(vfb->sdl.enable)) {
-        libxl_defbool_setdefault(&vfb->sdl.opengl, false);
-    }
+    libxl_defbool_setdefault(&vfb->sdl.opengl, false);
 
     return 0;
 }