Libxl regression on pv domU start

Libxl regression on pv domU start

[Fantu]

Dom0 is Wheezy 64 bit with xen-unstable from source.
With changeset 24858:a88ba599add1 work, after update to 24967:33659563f589
not.

xl create /etc/xen/lucid.cfg
Parsing config file /etc/xen/lucid.cfg
xl: libxl.c:214: libxl_defbool_val: Assertion
`!libxl_defbool_is_default(db)' failed.
Annullato

xl configuration file: /etc/xen/lucid.cfg
-----------------------------------------------
name="lucid"
vcpus=2
memory=512
disk=['/mnt/vm/disks/lucid.disk1.xm,raw,xvda1,rw',
'/mnt/vm/disks/lucid.disk2.xm,raw,xvda2,rw', '/dev/sr0,raw,xvdb,ro,cdrom']
vif=['bridge=xenbr0']
vfb=['vnc=1,vncunused=1,vnclisten=0.0.0.0,keymap=it']
bootloader = '/usr/bin/pygrub'
-----------------------------------------------


--
View this message in context: http://xen.1045712.n5.nabble.com/Libxl-regression-on-pv-domU-start-tp5540887p5540887.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: Libxl regression on pv domU start

[Ian Campbell]

On Tue, 2012-03-06 at 09:00 -0500, Fantu wrote:
> Dom0 is Wheezy 64 bit with xen-unstable from source.
> With changeset 24858:a88ba599add1 work, after update to 24967:33659563f589
> not.
> 
> xl create /etc/xen/lucid.cfg
> Parsing config file /etc/xen/lucid.cfg
> xl: libxl.c:214: libxl_defbool_val: Assertion
> `!libxl_defbool_is_default(db)' failed.
> Annullato

The following fixes this for me.

8<----------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1331043402 0
# Node ID 7cedb78a4a1d7b410a787da6401044485a82e1b3
# Parent  e8efe0a654517d9695c391b55b07612ebe79b409
libxl: always set a default value for VFB.opengl

Fixes an assertion reported by Fantu.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r e8efe0a65451 -r 7cedb78a4a1d tools/libxl/libxl.c
--- a/tools/libxl/libxl.c	Fri Mar 02 21:06:14 2012 +0000
+++ b/tools/libxl/libxl.c	Tue Mar 06 14:16:42 2012 +0000
@@ -2255,9 +2255,7 @@ int libxl__device_vfb_setdefault(libxl__
     }
 
     libxl_defbool_setdefault(&vfb->sdl.enable, false);
-    if (libxl_defbool_val(vfb->sdl.enable)) {
-        libxl_defbool_setdefault(&vfb->sdl.opengl, false);
-    }
+    libxl_defbool_setdefault(&vfb->sdl.opengl, false);
 
     return 0;
 }

Re: Libxl regression on pv domU start

[Fantu]

Ian Campbell-10 wrote
> 
> On Tue, 2012-03-06 at 09:00 -0500, Fantu wrote:
>> Dom0 is Wheezy 64 bit with xen-unstable from source.
>> With changeset 24858:a88ba599add1 work, after update to
>> 24967:33659563f589
>> not.
>> 
>> xl create /etc/xen/lucid.cfg
>> Parsing config file /etc/xen/lucid.cfg
>> xl: libxl.c:214: libxl_defbool_val: Assertion
>> `!libxl_defbool_is_default(db)' failed.
>> Annullato
> 
> The following fixes this for me.
> 
> 8<----------------------------
> 
> # HG changeset patch
> # User Ian Campbell &lt;ian.campbell@&gt;
> # Date 1331043402 0
> # Node ID 7cedb78a4a1d7b410a787da6401044485a82e1b3
> # Parent  e8efe0a654517d9695c391b55b07612ebe79b409
> libxl: always set a default value for VFB.opengl
> 
> Fixes an assertion reported by Fantu.
> 
> Signed-off-by: Ian Campbell &lt;ian.campbell@&gt;
> 
> diff -r e8efe0a65451 -r 7cedb78a4a1d tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c	Fri Mar 02 21:06:14 2012 +0000
> +++ b/tools/libxl/libxl.c	Tue Mar 06 14:16:42 2012 +0000
> @@ -2255,9 +2255,7 @@ int libxl__device_vfb_setdefault(libxl__
>      }
>  
>      libxl_defbool_setdefault(&vfb->sdl.enable, false);
> -    if (libxl_defbool_val(vfb->sdl.enable)) {
> -        libxl_defbool_setdefault(&vfb->sdl.opengl, false);
> -    }
> +    libxl_defbool_setdefault(&vfb->sdl.opengl, false);
>  
>      return 0;
>  }
> 
> 

Patch applied, problem solved.

--
View this message in context: http://xen.1045712.n5.nabble.com/Libxl-regression-on-pv-domU-start-tp5540887p5540987.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: Libxl regression on pv domU start

[Ian Jackson]

Ian Campbell writes ("Re: [Xen-devel] Libxl regression on pv domU start"):
> libxl: always set a default value for VFB.opengl
> 
> Fixes an assertion reported by Fantu.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Re: Libxl regression on pv domU start

[Ian Jackson]

> > libxl: always set a default value for VFB.opengl

> Patch applied, problem solved.

Great, thanks all.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>