From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] tools/configure: correct
 enable/disable-feature option
Date: Wed, 14 Mar 2012 19:16:48 +0000
Message-ID: <1331752608.13956.4.camel@dagon.hellion.org.uk>
References: <36690251f6bfe153f390.1331748800@probook.site>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <36690251f6bfe153f390.1331748800@probook.site>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2012-03-14 at 18:13 +0000, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1331748796 -3600
> # Node ID 36690251f6bfe153f390ef200ff286e64f2582d7
> # Parent  cd473b1fb313bb107cf1c32ce224f265a5de097e
> tools/configure: correct enable/disable-feature option
> 
> If --disable-feature is not specified then feature should default to n.

Maybe I'm misunderstanding what you are saying. I'd have though that it
would depend on the feature whether it was on by default or not and in
other cases it will depend on whether the prerequisites are met.

> But with the current code disable with set feature to y, and enable will
> set feature to n. Reverse the logic in the two .m4 files to use correct
> default values.
> The failure currently is that default := is y while it should be n.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> diff -r cd473b1fb313 -r 36690251f6bf tools/m4/disable_feature.m4
> --- a/tools/m4/disable_feature.m4
> +++ b/tools/m4/disable_feature.m4
> @@ -7,7 +7,7 @@ AS_IF([test "x$enable_$1" = "xno"], [
>  ], [test "x$enable_$1" = "xyes"], [
>      ax_cv_$1="y"
>  ], [test -z $ax_cv_$1], [
> -    ax_cv_$1="y"
> +    ax_cv_$1="n"
>  ])
>  $1=$ax_cv_$1
>  AC_SUBST($1)])
> diff -r cd473b1fb313 -r 36690251f6bf tools/m4/enable_feature.m4
> --- a/tools/m4/enable_feature.m4
> +++ b/tools/m4/enable_feature.m4
> @@ -7,7 +7,7 @@ AS_IF([test "x$enable_$1" = "xyes"], [
>  ], [test "x$enable_$1" = "xno"], [
>      ax_cv_$1="n"
>  ], [test -z $ax_cv_$1], [
> -    ax_cv_$1="n"
> +    ax_cv_$1="y"
>  ])
>  $1=$ax_cv_$1
>  AC_SUBST($1)])
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel