xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] svm: amend c/s 24990:322300fd2ebd (fake BU_CFG MSR on AMD revF)
Date: Thu, 15 Mar 2012 14:00:43 +0000	[thread overview]
Message-ID: <1331820043.908.111.camel@elijah> (raw)
In-Reply-To: <4F61EFF80200007800078A9E@nat28.tlf.novell.com>

On Thu, 2012-03-15 at 12:34 +0000, Jan Beulich wrote:
> Let's restrict such a hack to the known affected family.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I haven't tested it, but in principle:
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

Thanks Jan.

I'll see if I can get this back-ported to the XS patchqueue, so we can
test to make sure it works on all the hardware we have available.

 -George

> 
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -1505,7 +1505,7 @@ static int svm_msr_read_intercept(unsign
>          if ( rdmsr_safe(msr, *msr_content) == 0 )
>              break;
>  
> -        if ( msr == MSR_F10_BU_CFG )
> +        if ( boot_cpu_data.x86 == 0xf && msr == MSR_F10_BU_CFG )
>          {
>              /* Win2k8 x64 reads this MSR on revF chips, where it
>               * wasn't publically available; it uses a magic constant
> 
> 
> 

      parent reply	other threads:[~2012-03-15 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15 12:34 [PATCH] svm: amend c/s 24990:322300fd2ebd (fake BU_CFG MSR on AMD revF) Jan Beulich
2012-03-15 13:54 ` Keir Fraser
2012-03-15 14:00 ` George Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331820043.908.111.camel@elijah \
    --to=george.dunlap@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).