From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] svm: amend c/s 24990:322300fd2ebd (fake
 BU_CFG MSR on AMD revF)
Date: Thu, 15 Mar 2012 14:00:43 +0000
Message-ID: <1331820043.908.111.camel@elijah>
References: <4F61EFF80200007800078A9E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <4F61EFF80200007800078A9E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2012-03-15 at 12:34 +0000, Jan Beulich wrote:
> Let's restrict such a hack to the known affected family.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I haven't tested it, but in principle:
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

Thanks Jan.

I'll see if I can get this back-ported to the XS patchqueue, so we can
test to make sure it works on all the hardware we have available.

 -George

> 
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -1505,7 +1505,7 @@ static int svm_msr_read_intercept(unsign
>          if ( rdmsr_safe(msr, *msr_content) == 0 )
>              break;
>  
> -        if ( msr == MSR_F10_BU_CFG )
> +        if ( boot_cpu_data.x86 == 0xf && msr == MSR_F10_BU_CFG )
>          {
>              /* Win2k8 x64 reads this MSR on revF chips, where it
>               * wasn't publically available; it uses a magic constant
> 
> 
>