From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH 15/20] libxl: include <_libxl_paths.h> in libxl_internal.h Date: Fri, 16 Mar 2012 16:26:50 +0000 Message-ID: <1331915215-10477-16-git-send-email-ian.jackson@eu.citrix.com> References: <1331915215-10477-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331915215-10477-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xensource.com Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org Ie, we permit general code in libxl direct access to the manifest constants such as XEN_RUN_DIR. This simplifies their use in (eg) format strings. This might be controversial because it will make it difficult to make any of these runtime-configurable later without changing lots of use sites. But I don't think it's likely we'll want to do that. For the moment, leave existing call sites of all the functions in libxl_paths.c unchanged. The simplified use arrangements can be used in new code and when we update call sites for other reasons. Signed-off-by: Ian Jackson --- tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_paths.c | 1 - 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 69b6f74..983de3e 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -51,6 +51,7 @@ #include #include "libxl.h" +#include "_libxl_paths.h" #if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 1) #define _hidden __attribute__((visibility("hidden"))) diff --git a/tools/libxl/libxl_paths.c b/tools/libxl/libxl_paths.c index a95d29f..388b344 100644 --- a/tools/libxl/libxl_paths.c +++ b/tools/libxl/libxl_paths.c @@ -14,7 +14,6 @@ #include "libxl_osdeps.h" /* must come before any other headers */ #include "libxl_internal.h" -#include "_libxl_paths.h" const char *libxl_sbindir_path(void) { -- 1.7.2.5