From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 19/20] libxl: Clean up setdefault in do_domain_create Date: Fri, 16 Mar 2012 19:08:17 +0000 Message-ID: <1331924897.13956.58.camel@dagon.hellion.org.uk> References: <1331915215-10477-1-git-send-email-ian.jackson@eu.citrix.com> <1331915215-10477-20-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331915215-10477-20-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Fri, 2012-03-16 at 16:26 +0000, Ian Jackson wrote: > do_domain_create called libxl__domain_create_info_setdefault twice. Thanks, probably some sort of rebase snafu while I was working on that series. > Signed-off-by: Ian Jackson Acked-by: Ian Campbell > --- > tools/libxl/libxl_create.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > index 8417661..30dbc32 100644 > --- a/tools/libxl/libxl_create.c > +++ b/tools/libxl/libxl_create.c > @@ -539,9 +539,6 @@ static int do_domain_create(libxl__gc *gc, libxl_domain_config *d_config, > ret = libxl__domain_create_info_setdefault(gc, &d_config->c_info); > if (ret) goto error_out; > > - ret = libxl__domain_create_info_setdefault(gc, &d_config->c_info); > - if (ret) goto error_out; > - > ret = libxl__domain_make(gc, &d_config->c_info, &domid); > if (ret) { > LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "cannot make domain: %d", ret);