From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xensource.com
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
David Vrabel <david.vrabel@citrix.com>
Subject: [PATCH] kexec: provide crashinfo_maxaddr_bits if !CONFIG_KEXEC
Date: Mon, 19 Mar 2012 14:15:25 +0000 [thread overview]
Message-ID: <1332166525-29333-1-git-send-email-david.vrabel@citrix.com> (raw)
From: David Vrabel <david.vrabel@citrix.com>
Fix the build where !CONFIG_KEXEC (e.g., arm) by providing a default
crashinfo_maxaddr_bits.
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
Andy,
A cleaner fix might be to replace MEMF_bits(crashinfo_max_addr_bits)
with a function (e.g., crashinfo_mem_flags()), and provide an inline
stub when !CONFIG_KEXEC.
David
---
xen/drivers/char/console.c | 2 --
xen/include/xen/kexec.h | 8 ++++++++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 5cbbf81..e10bed5 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -22,9 +22,7 @@
#include <xen/guest_access.h>
#include <xen/shutdown.h>
#include <xen/vga.h>
-#ifdef CONFIG_KEXEC
#include <xen/kexec.h>
-#endif
#include <asm/debugger.h>
#include <asm/div64.h>
#include <xen/hypercall.h> /* for do_console_io */
diff --git a/xen/include/xen/kexec.h b/xen/include/xen/kexec.h
index 8e9c1d3..b3ca8b0 100644
--- a/xen/include/xen/kexec.h
+++ b/xen/include/xen/kexec.h
@@ -1,6 +1,8 @@
#ifndef __XEN_KEXEC_H__
#define __XEN_KEXEC_H__
+#ifdef CONFIG_KEXEC
+
#include <public/kexec.h>
#include <asm/percpu.h>
#include <xen/elfcore.h>
@@ -76,6 +78,12 @@ void vmcoreinfo_append_str(const char *fmt, ...)
vmcoreinfo_append_str("OFFSET(%s.%s)=%lu\n", #name, #field, \
(unsigned long)offsetof(struct name, sub.field))
+#else /* !CONFIG_KEXEC */
+
+#define crashinfo_maxaddr_bits 0
+
+#endif
+
#endif /* __XEN_KEXEC_H__ */
/*
--
1.7.2.5
next reply other threads:[~2012-03-19 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 14:15 David Vrabel [this message]
2012-03-19 14:28 ` [PATCH] kexec: provide crashinfo_maxaddr_bits if !CONFIG_KEXEC Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332166525-29333-1-git-send-email-david.vrabel@citrix.com \
--to=david.vrabel@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).