From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Campbell <ian.campbell@citrix.com>,
David Vrabel <david.vrabel@citrix.com>
Subject: [PATCH 07/11] arm: remove the hack for loading vmlinux images
Date: Mon, 19 Mar 2012 17:52:05 +0000 [thread overview]
Message-ID: <1332179529-1828-8-git-send-email-david.vrabel@citrix.com> (raw)
In-Reply-To: <1332179529-1828-1-git-send-email-david.vrabel@citrix.com>
From: David Vrabel <david.vrabel@citrix.com>
Don't adjust the RAM location/size when loading an ELF for dom0. It
was vmlinux specific and no longer needed because Linux can be loaded
from a zImage. Support for loading ELF images is not removed as it
may be useful for loading things other than the Linux kernel.
This also makes preparing the device tree for dom0 easier.
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
xen/arch/arm/kernel.c | 11 ++---------
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/xen/arch/arm/kernel.c b/xen/arch/arm/kernel.c
index 71a204d..dd757e5 100644
--- a/xen/arch/arm/kernel.c
+++ b/xen/arch/arm/kernel.c
@@ -91,7 +91,6 @@ static void kernel_zimage_load(struct kernel_info *info)
/**
* Check the image is a zImage and return the load address and length
- * (FIXME: including any appended DTB).
*/
static int kernel_try_zimage_prepare(struct kernel_info *info)
{
@@ -117,8 +116,6 @@ static int kernel_try_zimage_prepare(struct kernel_info *info)
end += be32_to_cpu(dtb_hdr.total_size);
}
- /* FIXME: get RAM location from appended DTB (if there is one)? */
-
/*
* If start is zero, the zImage is position independent -- load it
* at 32k from start of RAM.
@@ -166,13 +163,9 @@ static int kernel_try_elf_prepare(struct kernel_info *info)
return rc;
/*
- * FIXME: can the ELF header be used to find the physical address
- * to load the image to? Instead of making virt == phys by
- * relocating the guest's RAM.
+ * TODO: can the ELF header be used to find the physical address
+ * to load the image to? Instead of assuming virt == phys.
*/
- info->ram_start = 0xc0000000;
- info->ram_end = 0xc8000000;
-
info->entry = info->elf.parms.virt_entry;
info->load = kernel_elf_load;
--
1.7.2.5
next prev parent reply other threads:[~2012-03-19 17:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 17:51 [PATCHv2 00/11] arm: pass a device tree to dom0 David Vrabel
2012-03-19 17:51 ` [PATCH 01/11] libfdt: move headers to xen/include/xen/libfdt/ David Vrabel
2012-03-19 17:58 ` David Vrabel
2012-03-19 17:52 ` [PATCH 02/11] MAINTAINERS: add device tree maintainer David Vrabel
2012-03-19 17:54 ` Keir Fraser
2012-03-19 17:52 ` [PATCH 03/11] device tree: follow coding style David Vrabel
2012-03-19 17:52 ` [PATCH 04/11] device tree: correctly ignore unit-address when matching nodes by name David Vrabel
2012-03-19 17:52 ` [PATCH 05/11] device tree: add device_tree_for_each_node() David Vrabel
2012-03-22 11:12 ` Ian Campbell
2012-03-22 12:47 ` David Vrabel
2012-03-19 17:52 ` [PATCH 06/11] device tree: add device_tree_dump() to print a flat device tree David Vrabel
2012-03-19 17:52 ` David Vrabel [this message]
2012-03-19 17:52 ` [PATCH 08/11] device tree, arm: supply a flat device tree to dom0 David Vrabel
2012-03-20 10:43 ` David Vrabel
2012-03-20 10:52 ` Ian Campbell
2012-03-22 14:06 ` Ian Campbell
2012-03-22 14:27 ` David Vrabel
2012-03-22 17:12 ` David Vrabel
2012-03-19 17:52 ` [PATCH 09/11] Allow cmdline_parse() to be used with const strings David Vrabel
2012-03-19 17:54 ` Keir Fraser
2012-03-19 17:52 ` [PATCH 10/11] arm: use bootargs for the command line David Vrabel
2012-03-22 14:22 ` Ian Campbell
2012-03-22 14:30 ` Ian Campbell
2012-03-22 15:03 ` David Vrabel
2012-03-19 17:52 ` [PATCH 11/11] arm: add dom0_mem command line argument David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332179529-1828-8-git-send-email-david.vrabel@citrix.com \
--to=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).