From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 09/19] tools: Use PTHREAD_CFLAGS, _LDFLAGS, _LIBS
Date: Wed, 11 Apr 2012 13:59:31 +0100 [thread overview]
Message-ID: <1334149181-2834-10-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1334149181-2834-1-git-send-email-ian.jackson@eu.citrix.com>
Replace all literal occurrences of -lpthread and -pthread in Makefiles
by references to PTHREAD_CFLAGS, PTHREAD_LDFLAGS and PTHREAD_LIBS.
These are the new variables set by configure, and currently expand to
-pthread on the compilation and link lines as is required.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
tools/blktap/drivers/Makefile | 7 +++++--
tools/libfsimage/common/Makefile | 5 ++++-
tools/vtpm_manager/manager/Makefile | 4 +++-
tools/xenpaging/Makefile | 5 +++--
4 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/tools/blktap/drivers/Makefile b/tools/blktap/drivers/Makefile
index addb2fe..941592e 100644
--- a/tools/blktap/drivers/Makefile
+++ b/tools/blktap/drivers/Makefile
@@ -35,8 +35,11 @@ else
AIOLIBS := -laio
endif
-LDLIBS_blktapctrl := $(MEMSHRLIBS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenstore) -L../lib -lblktap -lrt -lm -lpthread
-LDLIBS_img := $(AIOLIBS) $(CRYPT_LIB) -lpthread -lz
+CFLAGS += $(PTHREAD_CFLAGS)
+LDFLAGS += $(PTHREAD_LDFLAGS)
+
+LDLIBS_blktapctrl := $(MEMSHRLIBS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenstore) -L../lib -lblktap -lrt -lm $(PTHREAD_LIBS)
+LDLIBS_img := $(AIOLIBS) $(CRYPT_LIB) $(PTHREAD_LIBS) -lz
BLK-OBJS-y := block-aio.o
BLK-OBJS-y += block-sync.o
diff --git a/tools/libfsimage/common/Makefile b/tools/libfsimage/common/Makefile
index 11621e7..3684913 100644
--- a/tools/libfsimage/common/Makefile
+++ b/tools/libfsimage/common/Makefile
@@ -8,6 +8,9 @@ LDFLAGS-$(CONFIG_SunOS) = -Wl,-M -Wl,mapfile-SunOS
LDFLAGS-$(CONFIG_Linux) = -Wl,mapfile-GNU
LDFLAGS = $(LDFLAGS-y)
+CFLAGS += $(PTHREAD_CFLAGS)
+LDFLAGS += $(PTHREAD_LDFLAGS)
+
LIB_SRCS-y = fsimage.c fsimage_plugin.c fsimage_grub.c
PIC_OBJS := $(patsubst %.c,%.opic,$(LIB_SRCS-y))
@@ -37,7 +40,7 @@ libfsimage.so.$(MAJOR): libfsimage.so.$(MAJOR).$(MINOR)
ln -sf $< $@
libfsimage.so.$(MAJOR).$(MINOR): $(PIC_OBJS)
- $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libfsimage.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ -lpthread
+ $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libfsimage.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(PTHREAD_LIBS)
-include $(DEPS)
diff --git a/tools/vtpm_manager/manager/Makefile b/tools/vtpm_manager/manager/Makefile
index 149f01d..7564af1 100644
--- a/tools/vtpm_manager/manager/Makefile
+++ b/tools/vtpm_manager/manager/Makefile
@@ -33,4 +33,6 @@ $(BIN): $(OBJS)
# libraries
LIBS += ../tcs/libTCS.a ../util/libTCGUtils.a ../crypto/libtcpaCrypto.a
-LIBS += -lcrypto -lpthread -lm
+LIBS += -lcrypto $(PTHREAD_LIBS) -lm
+CFLAGS += $(PTHREAD_CFLAGS)
+LDFLAGS += $(PTHREAD_LDFLAGS)
diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
index 08230a6..548d9dd 100644
--- a/tools/xenpaging/Makefile
+++ b/tools/xenpaging/Makefile
@@ -1,8 +1,9 @@
XEN_ROOT=$(CURDIR)/../..
include $(XEN_ROOT)/tools/Rules.mk
-CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenstore)
-LDLIBS += $(LDLIBS_libxenctrl) $(LDLIBS_libxenstore) -pthread
+CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenstore) $(PTHREAD_CFLAGS)
+LDLIBS += $(LDLIBS_libxenctrl) $(LDLIBS_libxenstore) $(PTHREAD_LIBS)
+LDFLAGS += $(PTHREAD_LDFLAGS)
POLICY = default
--
1.7.2.5
next prev parent reply other threads:[~2012-04-11 12:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 12:59 [PATCH v5 00/19] libxl: improvements, prep for subprocess handling Ian Jackson
2012-04-11 12:59 ` [PATCH 01/19] .gitignore: Add a missing file Ian Jackson
2012-04-11 12:59 ` [PATCH 02/19] libxl: ao: allow immediate completion Ian Jackson
2012-04-11 12:59 ` [PATCH 03/19] libxl: fix hang due to libxl__initiate_device_remove Ian Jackson
2012-04-11 12:59 ` [PATCH 04/19] libxl: Fix eventloop_iteration over-locking Ian Jackson
2012-04-11 12:59 ` [PATCH 05/19] libxl: remove poller from list in libxl__poller_get Ian Jackson
2012-04-11 12:59 ` [PATCH 06/19] libxl: Fix leak of ctx->lock Ian Jackson
2012-04-11 12:59 ` [PATCH 07/19] tools: Correct PTHREAD options in config/StdGNU.mk Ian Jackson
2012-04-11 12:59 ` [PATCH 08/19] libxl: Use PTHREAD_CFLAGS, LDFLAGS, LIBS Ian Jackson
2012-04-11 12:59 ` Ian Jackson [this message]
2012-04-11 12:59 ` [PATCH 10/19] libxl: Crash (more sensibly) on malloc failure Ian Jackson
2012-04-11 12:59 ` [PATCH 11/19] libxl: Make libxl__zalloc et al tolerate a NULL gc Ian Jackson
2012-04-11 12:59 ` [PATCH 12/19] libxl: Introduce some convenience macros Ian Jackson
2012-04-11 12:59 ` [PATCH 13/19] libxl: include <ctype.h> and introduce CTYPE helper macro Ian Jackson
2012-04-11 12:59 ` [PATCH 14/19] libxl: Provide libxl_string_list_length Ian Jackson
2012-04-11 12:59 ` [PATCH 15/19] libxl: include <_libxl_paths.h> in libxl_internal.h Ian Jackson
2012-04-11 12:59 ` [PATCH 16/19] libxl: abolish libxl_ctx_postfork Ian Jackson
2012-04-11 12:59 ` [PATCH 17/19] libxl: libxl_event.c:beforepoll_internal, REQUIRE_FDS Ian Jackson
2012-04-11 12:59 ` [PATCH 18/19] libxl: Protect fds with CLOEXEC even with forking threads Ian Jackson
2012-04-11 12:59 ` [PATCH 19/19] libxl: provide STATE_AO_GC Ian Jackson
2012-04-11 13:35 ` [PATCH v5 00/19] libxl: improvements, prep for subprocess handling Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334149181-2834-10-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).