From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 13/19] libxl: include <ctype.h> and introduce CTYPE helper macro
Date: Wed, 11 Apr 2012 13:59:35 +0100 [thread overview]
Message-ID: <1334149181-2834-14-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1334149181-2834-1-git-send-email-ian.jackson@eu.citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
tools/libxl/libxl_internal.h | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 95c34f3..b35421f 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -33,6 +33,7 @@
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
+#include <ctype.h>
#include <sys/mman.h>
#include <sys/poll.h>
@@ -1469,6 +1470,25 @@ static inline void libxl__ctx_unlock(libxl_ctx *ctx) {
} while(0)
+/*
+ * int CTYPE(ISFOO, char c);
+ * int CTYPE(toupper, char c);
+ * int CTYPE(tolower, char c);
+ *
+ * This is necessary because passing a simple char to a ctype.h
+ * is forbidden. ctype.h macros take ints derived from _unsigned_ chars.
+ *
+ * If you have a char which might be EOF then you should already have
+ * it in an int representing an unsigned char, and you can use the
+ * <ctype.h> macros directly. This generally happens only with values
+ * from fgetc et al.
+ *
+ * For any value known to be a character (eg, anything that came from
+ * a char[]), use CTYPE.
+ */
+#define CTYPE(isfoo,c) (isfoo((unsigned char)(c)))
+
+
#endif
/*
--
1.7.2.5
next prev parent reply other threads:[~2012-04-11 12:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 12:59 [PATCH v5 00/19] libxl: improvements, prep for subprocess handling Ian Jackson
2012-04-11 12:59 ` [PATCH 01/19] .gitignore: Add a missing file Ian Jackson
2012-04-11 12:59 ` [PATCH 02/19] libxl: ao: allow immediate completion Ian Jackson
2012-04-11 12:59 ` [PATCH 03/19] libxl: fix hang due to libxl__initiate_device_remove Ian Jackson
2012-04-11 12:59 ` [PATCH 04/19] libxl: Fix eventloop_iteration over-locking Ian Jackson
2012-04-11 12:59 ` [PATCH 05/19] libxl: remove poller from list in libxl__poller_get Ian Jackson
2012-04-11 12:59 ` [PATCH 06/19] libxl: Fix leak of ctx->lock Ian Jackson
2012-04-11 12:59 ` [PATCH 07/19] tools: Correct PTHREAD options in config/StdGNU.mk Ian Jackson
2012-04-11 12:59 ` [PATCH 08/19] libxl: Use PTHREAD_CFLAGS, LDFLAGS, LIBS Ian Jackson
2012-04-11 12:59 ` [PATCH 09/19] tools: Use PTHREAD_CFLAGS, _LDFLAGS, _LIBS Ian Jackson
2012-04-11 12:59 ` [PATCH 10/19] libxl: Crash (more sensibly) on malloc failure Ian Jackson
2012-04-11 12:59 ` [PATCH 11/19] libxl: Make libxl__zalloc et al tolerate a NULL gc Ian Jackson
2012-04-11 12:59 ` [PATCH 12/19] libxl: Introduce some convenience macros Ian Jackson
2012-04-11 12:59 ` Ian Jackson [this message]
2012-04-11 12:59 ` [PATCH 14/19] libxl: Provide libxl_string_list_length Ian Jackson
2012-04-11 12:59 ` [PATCH 15/19] libxl: include <_libxl_paths.h> in libxl_internal.h Ian Jackson
2012-04-11 12:59 ` [PATCH 16/19] libxl: abolish libxl_ctx_postfork Ian Jackson
2012-04-11 12:59 ` [PATCH 17/19] libxl: libxl_event.c:beforepoll_internal, REQUIRE_FDS Ian Jackson
2012-04-11 12:59 ` [PATCH 18/19] libxl: Protect fds with CLOEXEC even with forking threads Ian Jackson
2012-04-11 12:59 ` [PATCH 19/19] libxl: provide STATE_AO_GC Ian Jackson
2012-04-11 13:35 ` [PATCH v5 00/19] libxl: improvements, prep for subprocess handling Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334149181-2834-14-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).