From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [PATCH 19/19] libxl: provide STATE_AO_GC
Date: Wed, 11 Apr 2012 13:59:41 +0100 [thread overview]
Message-ID: <1334149181-2834-20-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1334149181-2834-1-git-send-email-ian.jackson@eu.citrix.com>
Provide a convenience macro for use in ao callback functions, and
document that it should be used.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
tools/libxl/libxl_internal.h | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index a8372bb..a4b933b 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -1266,9 +1266,10 @@ _hidden void libxl__egc_cleanup(libxl__egc *egc);
* - Note that during callback functions, two gcs are available:
* - The one in egc, whose lifetime is only this callback
* - The one in ao, whose lifetime is the asynchronous operation
- * Usually callback function should use CONTAINER_OF
- * to obtain its own structure, containing a pointer to the ao,
- * and then use the gc from that ao.
+ * Usually callback function should use CONTAINER_OF to obtain its
+ * own state structure, containing a pointer to the ao. It should
+ * then obtain the ao and use the ao's gc; this is most easily done
+ * using the convenience macro STATE_AO_GC.
*/
#define AO_CREATE(ctx, domid, ao_how) \
@@ -1298,6 +1299,10 @@ _hidden void libxl__egc_cleanup(libxl__egc *egc);
#define AO_GC \
libxl__gc *const gc = &ao->gc
+#define STATE_AO_GC(op_ao) \
+ libxl__ao *const ao = (op_ao); \
+ AO_GC
+
/* All of these MUST be called with the ctx locked.
* libxl__ao_inprogress MUST be called with the ctx locked exactly once. */
--
1.7.2.5
next prev parent reply other threads:[~2012-04-11 12:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 12:59 [PATCH v5 00/19] libxl: improvements, prep for subprocess handling Ian Jackson
2012-04-11 12:59 ` [PATCH 01/19] .gitignore: Add a missing file Ian Jackson
2012-04-11 12:59 ` [PATCH 02/19] libxl: ao: allow immediate completion Ian Jackson
2012-04-11 12:59 ` [PATCH 03/19] libxl: fix hang due to libxl__initiate_device_remove Ian Jackson
2012-04-11 12:59 ` [PATCH 04/19] libxl: Fix eventloop_iteration over-locking Ian Jackson
2012-04-11 12:59 ` [PATCH 05/19] libxl: remove poller from list in libxl__poller_get Ian Jackson
2012-04-11 12:59 ` [PATCH 06/19] libxl: Fix leak of ctx->lock Ian Jackson
2012-04-11 12:59 ` [PATCH 07/19] tools: Correct PTHREAD options in config/StdGNU.mk Ian Jackson
2012-04-11 12:59 ` [PATCH 08/19] libxl: Use PTHREAD_CFLAGS, LDFLAGS, LIBS Ian Jackson
2012-04-11 12:59 ` [PATCH 09/19] tools: Use PTHREAD_CFLAGS, _LDFLAGS, _LIBS Ian Jackson
2012-04-11 12:59 ` [PATCH 10/19] libxl: Crash (more sensibly) on malloc failure Ian Jackson
2012-04-11 12:59 ` [PATCH 11/19] libxl: Make libxl__zalloc et al tolerate a NULL gc Ian Jackson
2012-04-11 12:59 ` [PATCH 12/19] libxl: Introduce some convenience macros Ian Jackson
2012-04-11 12:59 ` [PATCH 13/19] libxl: include <ctype.h> and introduce CTYPE helper macro Ian Jackson
2012-04-11 12:59 ` [PATCH 14/19] libxl: Provide libxl_string_list_length Ian Jackson
2012-04-11 12:59 ` [PATCH 15/19] libxl: include <_libxl_paths.h> in libxl_internal.h Ian Jackson
2012-04-11 12:59 ` [PATCH 16/19] libxl: abolish libxl_ctx_postfork Ian Jackson
2012-04-11 12:59 ` [PATCH 17/19] libxl: libxl_event.c:beforepoll_internal, REQUIRE_FDS Ian Jackson
2012-04-11 12:59 ` [PATCH 18/19] libxl: Protect fds with CLOEXEC even with forking threads Ian Jackson
2012-04-11 12:59 ` Ian Jackson [this message]
2012-04-11 13:35 ` [PATCH v5 00/19] libxl: improvements, prep for subprocess handling Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334149181-2834-20-git-send-email-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).