From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xensource.com
Cc: David Vrabel <david.vrabel@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>, Sheng Yang <sheng@yasker.org>
Subject: [PATCH] xen: always set the sched clock as unstable
Date: Fri, 13 Apr 2012 19:20:55 +0100 [thread overview]
Message-ID: <1334341255-11153-1-git-send-email-david.vrabel@citrix.com> (raw)
From: David Vrabel <david.vrabel@citrix.com>
The sched clock was considered stable based on the capabilities of the
underlying hardware. This does not make sense for Xen PV guests as:
a) the hardware TSC is not used directly as the clock source; and b)
guests may migrate to hosts with different hardware capabilities.
It is not clear to me whether the Xen clock source is supposed to be
stable and whether it should be stable across migration. For a clock
source to be stable it must be: a) monotonic; c) synchronized across
CPUs; and c) constant rate.
There have also been reports of systems with apparently unstable
clocks where clearing sched_clock_stable has fixed problems with
migrated VMs hanging.
So, always set the sched clock as unstable when using the Xen clock
source.
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
---
arch/x86/xen/time.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index 0296a95..8469b5a 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -473,6 +473,7 @@ static void __init xen_time_init(void)
do_settimeofday(&tp);
setup_force_cpu_cap(X86_FEATURE_TSC);
+ sched_clock_stable = 0;
xen_setup_runstate_info(cpu);
xen_setup_timer(cpu);
--
1.7.2.5
next reply other threads:[~2012-04-13 18:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 18:20 David Vrabel [this message]
2012-04-13 18:31 ` [PATCH] xen: always set the sched clock as unstable Sheng Yang
2012-04-13 18:39 ` David Vrabel
2012-04-13 18:33 ` Sheng Yang
2012-04-16 11:32 ` Jan Beulich
[not found] ` <4F8C1F6D020000780007E11A@nat28.tlf.novell.com>
2012-04-16 14:59 ` David Vrabel
[not found] ` <4F8C33E0.2080007@citrix.com>
2012-04-16 15:16 ` Tim Deegan
2012-04-16 15:17 ` Konrad Rzeszutek Wilk
2012-04-16 16:20 ` Dan Magenheimer
2012-04-16 16:05 ` Dan Magenheimer
[not found] ` <049b7b93-fb37-4962-b272-d786e1dcfacb@default>
2012-04-16 16:14 ` Jan Beulich
2012-04-16 16:26 ` David Vrabel
2012-04-16 17:08 ` Tim Deegan
[not found] ` <4F8C619C020000780007E34E@nat28.tlf.novell.com>
2012-04-16 17:22 ` Dan Magenheimer
[not found] ` <84023b26-a682-44b5-990e-1635da6949ff@default>
2012-04-17 7:27 ` Jan Beulich
[not found] ` <4F8D3778020000780007E63A@nat28.tlf.novell.com>
2012-04-17 15:36 ` Dan Magenheimer
[not found] ` <4F8C4818.8070603@citrix.com>
2012-04-16 17:30 ` Dan Magenheimer
[not found] ` <8a78da52-26b2-42a2-80c7-c1ab8aee86eb@default>
2012-04-17 7:47 ` Jan Beulich
[not found] ` <4F8D3C4E020000780007E658@nat28.tlf.novell.com>
2012-04-17 15:42 ` Dan Magenheimer
[not found] ` <20120416170827.GE13111@ocelot.phlegethon.org>
2012-04-16 17:52 ` Dan Magenheimer
[not found] ` <3e05ae0e-afe4-4ed7-b839-39a343cc0d06@default>
2012-04-16 18:17 ` Tim Deegan
[not found] ` <20120416181744.GF13111@ocelot.phlegethon.org>
2012-04-16 23:01 ` Sheng Yang
[not found] ` <CA+2rt41pCFV1haMAHo63rY9kx88VgiV419pf8Y=u2cXrdmGOBA@mail.gmail.com>
2012-04-17 0:29 ` Dan Magenheimer
2012-04-17 8:19 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334341255-11153-1-git-send-email-david.vrabel@citrix.com \
--to=david.vrabel@citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sheng@yasker.org \
--cc=tglx@linutronix.de \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).