From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] fix build error with seabios
Date: Wed, 25 Apr 2012 09:07:42 +0100 [thread overview]
Message-ID: <1335341262.4881.15.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20374.57450.417199.89376@mariner.uk.xensource.com>
On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
> >
> > Pass PYTHON down to seabios, so seabios will
> > use same python binary as whole xen tree does.
> > Fixes build error on NetBSD.
>
> Ian, does this look sensible to you ?
It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
is OK, so we might as well take this now.
Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the future
>
> > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > ----------------------------------------------------------------------
> > diff -r ab552da976a3 tools/firmware/Makefile
> > --- a/tools/firmware/Makefile Wed Apr 11 18:28:33 2012 +0200
> > +++ b/tools/firmware/Makefile Fri Apr 13 16:22:23 2012 +0200
> > @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
> > false ; \
> > fi
> > endif
> > - $(MAKE) subdirs-$@
> > + $(MAKE) PYTHON=$(PYTHON) subdirs-$@
> >
> >
> > .PHONY: install
> >
> > ----------------------------------------------------------------------
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-04-25 8:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 14:23 [PATCH] fix build error with seabios Christoph Egger
2012-04-24 17:18 ` Ian Jackson
2012-04-25 8:07 ` Ian Campbell [this message]
2012-04-25 8:43 ` Christoph Egger
2012-04-25 8:52 ` Ian Campbell
2012-04-25 9:10 ` Christoph Egger
2012-04-25 9:13 ` Christoph Egger
2012-04-25 9:18 ` Christoph Egger
2012-04-25 9:20 ` Ian Campbell
2012-04-25 9:52 ` Christoph Egger
2012-04-25 9:16 ` Ian Campbell
2012-04-25 9:21 ` Christoph Egger
2012-04-25 10:23 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335341262.4881.15.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).