From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] fix build error with seabios
Date: Wed, 25 Apr 2012 09:07:42 +0100
Message-ID: <1335341262.4881.15.camel@dagon.hellion.org.uk>
References: <4F8836C9.9080502@amd.com>
	<20374.57450.417199.89376@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20374.57450.417199.89376@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2012-04-24 at 18:18 +0100, Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] fix build error with seabios"):
> > 
> > Pass PYTHON down to seabios, so seabios will
> > use same python binary as whole xen tree does.
> > Fixes build error on NetBSD.
> 
> Ian, does this look sensible to you ?

It exports $(PYTHON) to all subdirs of tools/firmware, but I guess that
is OK, so we might as well take this now.

Does
subdirs-seabios: PYTHON=$(PYTHON)
(or something similar) work? Might be a better option in the future

> 
> > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> > 
> > ----------------------------------------------------------------------
> > diff -r ab552da976a3 tools/firmware/Makefile
> > --- a/tools/firmware/Makefile	Wed Apr 11 18:28:33 2012 +0200
> > +++ b/tools/firmware/Makefile	Fri Apr 13 16:22:23 2012 +0200
> > @@ -32,7 +32,7 @@ ifeq ($(CONFIG_ROMBIOS),y)
> >  	false ; \
> >  	fi
> >  endif
> > -	$(MAKE) subdirs-$@
> > +	$(MAKE) PYTHON=$(PYTHON) subdirs-$@
> >  
> >  
> >  .PHONY: install
> > 
> > ----------------------------------------------------------------------
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel