From: Ian Campbell <Ian.Campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ross Philipson <Ross.Philipson@citrix.com>
Subject: Re: vTPM patch does not apply
Date: Fri, 4 May 2012 09:33:58 +0100 [thread overview]
Message-ID: <1336120438.26385.13.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20120503155716.GA14354@aepfle.de>
On Thu, 2012-05-03 at 16:57 +0100, Olaf Hering wrote:
> On Thu, May 03, Olaf Hering wrote:
>
> > Perhaps I made a mistake somewhere in my queue of changes, or vtpm got
> > disabled for some reason. I will double check.
>
> While preparing the patch I accidently disabled vtpm in my rpm spec
> file, so the code was not exectued anymore.
> Sorry for that.
So should c5b7d49ca3ee be reverted for now? Or are you going to come up
with a fix soon?
> I see some nice patch handing in tools/firmware/etherboot/Makefile,
> which could be copied to tools/vtpm/Makefile. However, this would make
> the make targets updatepatches and orig in tools/vtpm/Makefile obsolete.
> Would that be an acceptable approach to maintain a stack of patches for
> vtpm?
It could be considered for 4.3. I'm not sure we want to be fiddling with
obscure parts of the build system for 4.2 at this stage. Lets just fix
the immediate breakage for 4.2.
Ian.
next prev parent reply other threads:[~2012-05-04 8:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 14:57 vTPM patch does not apply Ross Philipson
2012-05-03 15:18 ` Ian Campbell
2012-05-03 15:36 ` Olaf Hering
2012-05-03 15:48 ` Ross Philipson
2012-05-03 15:57 ` Olaf Hering
2012-05-04 8:33 ` Ian Campbell [this message]
2012-05-04 9:28 ` Olaf Hering
2012-05-04 10:19 ` Ian Jackson
2012-05-04 10:26 ` Olaf Hering
2012-05-04 10:27 ` Ian Campbell
2012-05-04 15:45 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336120438.26385.13.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Ross.Philipson@citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).