From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: vTPM patch does not apply Date: Fri, 4 May 2012 09:33:58 +0100 Message-ID: <1336120438.26385.13.camel@dagon.hellion.org.uk> References: <831D55AF5A11D64C9B4B43F59EEBF720A10D810DCA@FTLPMAILBOX02.citrite.net> <1336058302.20716.100.camel@zakaz.uk.xensource.com> <20120503153616.GA10918@aepfle.de> <20120503155716.GA14354@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120503155716.GA14354@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: "xen-devel@lists.xensource.com" , Ian Jackson , Ross Philipson List-Id: xen-devel@lists.xenproject.org On Thu, 2012-05-03 at 16:57 +0100, Olaf Hering wrote: > On Thu, May 03, Olaf Hering wrote: > > > Perhaps I made a mistake somewhere in my queue of changes, or vtpm got > > disabled for some reason. I will double check. > > While preparing the patch I accidently disabled vtpm in my rpm spec > file, so the code was not exectued anymore. > Sorry for that. So should c5b7d49ca3ee be reverted for now? Or are you going to come up with a fix soon? > I see some nice patch handing in tools/firmware/etherboot/Makefile, > which could be copied to tools/vtpm/Makefile. However, this would make > the make targets updatepatches and orig in tools/vtpm/Makefile obsolete. > Would that be an acceptable approach to maintain a stack of patches for > vtpm? It could be considered for 4.3. I'm not sure we want to be fiddling with obscure parts of the build system for 4.2 at this stage. Lets just fix the immediate breakage for 4.2. Ian.